Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Subcontracting Receipt GL Entries #31918

Merged
merged 4 commits into from
Sep 8, 2022
Merged

fix: Subcontracting Receipt GL Entries #31918

merged 4 commits into from
Sep 8, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Aug 22, 2022 •
edited
Loading

Account Debit Credit Remark
FG Warehouse A/C Stock Value Difference - -
Supplier Warehouse A/C - RM Cost -
Expense A/C - Service Cost item.expense_account or Default Expense Account
Additional Cost Expense A/C - Additional Cost -
Loss A/C - Stock Value Difference - FG Amount (SCR) item.expense_account or Default Expense Account

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022 •
edited
Loading

Codecov Report

Merging #31918 (f19049e) into develop (9d1be48) will increase coverage by 0.07%.
The diff coverage is 86.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #31918      +/-   ##
===========================================
+ Coverage    63.52%   63.59%   +0.07%     
===========================================
  Files          813      813              
  Lines        57665    57704      +39     
===========================================
+ Hits         36631    36698      +67     
+ Misses       21034    21006      -28
Impacted Files Coverage Δ
...stock/doctype/purchase_receipt/purchase_receipt.py 92.65% <ø> (-0.21%) ⬇️
...e/subcontracting_receipt/subcontracting_receipt.py 92.89% <82.05%> (-3.26%) ⬇️
erpnext/controllers/stock_controller.py 92.37% <100.00%> (+0.19%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-22.96%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 89.74% <0.00%> (-7.70%) ⬇️
...t/accounts/report/sales_register/sales_register.py 75.43% <0.00%> (-6.44%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 88.88% <0.00%> (-3.71%) ⬇️
... and 26 more

@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Aug 22, 2022
@s-aga-r s-aga-r marked this pull request as ready for review August 23, 2022 06:11
@s-aga-r s-aga-r removed the request for review from marination August 23, 2022 06:12
@rohitwaghchaure rohitwaghchaure merged commit 72d5366 into frappe:develop Sep 8, 2022
@s-aga-r s-aga-r mentioned this pull request Sep 8, 2022
Merged
s-aga-r added a commit that referenced this pull request Sep 8, 2022
@s-aga-r
fix: Subcontracting Receipt GL Entries (backport #31918) (#32124)
f2ab220 
fix: Subcontracting Receipt GL Entries
frappe-pr-bot pushed a commit that referenced this pull request Sep 13, 2022
@frappe-bot
chore(release): Bumped to Version 14.1.1
740c17c 
## [14.1.1](v14.1.0...v14.1.1) (2022-09-13)

### Bug Fixes

* AD not getting copied from SCO while creating a Material Transfer ([#32109](#32109)) ([09d8fa4](09d8fa4)), closes [#32106](#32106)
* add missing warehouse filter in BOM Stock Calculated report ([4e09203](4e09203))
* conflict ([a408722](a408722))
* consider Stock Entry purpose while getting total supplied qty ([5af0062](5af0062))
* customer code max characters limit issue ([#32177](#32177)) ([93e5100](93e5100))
* delete linked payment ledger entries no source doc deletion ([ccd0449](ccd0449))
* drop old notes column from lead and prospect ([ded6e7f](ded6e7f))
* **Employee:** shorter tab titles (backport [#32192](#32192)) ([#32193](#32193)) ([027e66f](027e66f))
* hide "Return of Components" button in closed SCO (backport [#32130](#32130)) ([#32131](#32131)) ([7840fed](7840fed))
* import error on bank statement import ([467ee97](467ee97))
* internal transfer flow ([4bac0da](4bac0da))
* inventory dimension filter's label not showing in the reort ([2d2eef6](2d2eef6))
* item wise sales register taxes and charges ([53f235b](53f235b))
* Migrate old lead notes as per the new format ([28b1d4e](28b1d4e))
* option to start reposting from repost item valuation ([6483195](6483195))
* pick_list - picked qty getting set to 1 ([3c3ab89](3c3ab89))
* promotional scheme min and max amount configuration ([702c16e](702c16e))
* QR Code multi currency issue ([d14a9a1](d14a9a1))
* Rate for internal PI have non stock UOM items ([c06e241](c06e241))
* remove EmployeeBoardingController (backport [#32139](#32139)) ([#32191](#32191)) ([944b8a0](944b8a0))
* remove multiple call to ple creation ([a2285d5](a2285d5))
* reposting not working for internal transferred purchase receipt ([7ce6729](7ce6729))
* require barcode item barcode ([#32111](#32111)) ([404668f](404668f)), closes [#31957](#31957)
* required_qty in BOM Stock Calculated report ([af883be](af883be))
* SCO Supplied Items returned-qty ([4568648](4568648))
* Set filter condition and spell in AR ([174c750](174c750))
* status filter for Subcontracting Order in Stock Entry ([844f120](844f120))
* Subcontracting Receipt GL Entries (backport [#31918](#31918)) ([#32124](#32124)) ([f2ab220](f2ab220))
* **UX:** make Item attachments public by default (backport [#32196](#32196)) ([#32197](#32197)) ([2c4867c](2c4867c))
* validate Subcontracting Order in Stock Entry ([d3cc9d4](d3cc9d4))

### Performance Improvements

* lesser SQL queries and no validation ([7bb5f6e](7bb5f6e))
@s-aga-r s-aga-r added bug and removed stock labels Sep 21, 2022
@commit-lint commit-lint bot mentioned this pull request Oct 12, 2022
Merged
@barredterra barredterra mentioned this pull request Mar 7, 2023
Closed
@s-aga-r s-aga-r deleted the fix/subcontracting-receipt/gl-entries branch April 15, 2023 09:58
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nabinhait nabinhait Awaiting requested review from nabinhait

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-aga-r @rohitwaghchaure