Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include payment against PO in AR/AP report #31942

Merged
merged 2 commits into from
Aug 25, 2022
Merged

fix: include payment against PO in AR/AP report #31942

merged 2 commits into from
Aug 25, 2022

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Aug 24, 2022 •
edited
Loading

Payments against Purchase Order/Sales Order should be included in Accounts Receivable/Payable report under the same Voucher no as outstanding amount.

Before:
before_ar_rpt

After:
after_ar_rpt

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022 •
edited
Loading

Codecov Report

Merging #31942 (36f5883) into develop (9c580dd) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #31942      +/-   ##
===========================================
- Coverage    63.25%   63.12%   -0.14%     
===========================================
  Files          813      813              
  Lines        57520    57555      +35     
===========================================
- Hits         36386    36331      -55     
- Misses       21134    21224      +90
Impacted Files Coverage Δ
erpnext/setup/doctype/item_group/item_group.py 66.94% <ø> (+0.56%) ⬆️
.../report/accounts_receivable/accounts_receivable.py 71.46% <100.00%> (+0.12%) ⬆️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-37.51%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-16.84%) ⬇️
erpnext/accounts/party.py 77.71% <0.00%> (-4.36%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 77.62% <0.00%> (-3.50%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 65.67% <0.00%> (-2.71%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-1.76%) ⬇️
... and 43 more

@ruthra-kumar
test: payments against so/po will show up as outstanding amount
36f5883 
1. Class will use FrappeTestCase fixture
2. setup and teardown methods are introduced
3. test for payments against SO
@ruthra-kumar ruthra-kumar merged commit ee889af into frappe:develop Aug 25, 2022
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2022

backport version-14-hotfix

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 2, 2022
Merged
ruthra-kumar added a commit that referenced this pull request Sep 2, 2022
@ruthra-kumar
Merge pull request #32055 from frappe/mergify/bp/version-14-hotfix/pr…
84865a8 
…-31942

fix: include payment against PO in AR/AP report (backport #31942)
@ruthra-kumar ruthra-kumar deleted the bug_ar_ap_report_include_payment_against_po branch June 14, 2023 16:07
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ruthra-kumar