Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: readd remarks field to payment ledger #32009

Merged

Conversation

ruthra-kumar
Copy link
Member

Add remarks field to Payment Ledger feature. Remarks field will be reintroduced in Accounts Receivable/Payable report.

Changes in PR:

  1. Readd remarks field to Payment Ledger Entry doctype
  2. Fetch value from GL Entry remarks on creation
  3. Refactor AR/AP report to include remarks field
  4. Patch to migrate old remarks from GL to payment ledger entry for existing data
  5. add patch to patches.txt

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #32009 (d522f13) into develop (9e43c9c) will decrease coverage by 0.33%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #32009      +/-   ##
===========================================
- Coverage    63.46%   63.13%   -0.34%     
===========================================
  Files          813      813              
  Lines        57585    57602      +17     
===========================================
- Hits         36546    36365     -181     
- Misses       21039    21237     +198     
Impacted Files Coverage Δ
erpnext/accounts/utils.py 72.63% <ø> (ø)
.../report/accounts_receivable/accounts_receivable.py 71.55% <50.00%> (-0.70%) ⬇️
erpnext/stock/doctype/stock_entry/stock_entry.py 81.07% <50.00%> (-0.07%) ⬇️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-42.77%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 59.64% <0.00%> (-26.32%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 65.57% <0.00%> (-21.32%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-19.81%) ⬇️
... and 32 more

@ruthra-kumar ruthra-kumar marked this pull request as ready for review August 29, 2022 14:17
@ruthra-kumar ruthra-kumar merged commit 25072e5 into frappe:develop Aug 29, 2022
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

backport version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Aug 29, 2022
…-32009

refactor: readd remarks field to payment ledger (backport #32009)
@ruthra-kumar ruthra-kumar deleted the add_remarks_to_payment_ledger branch June 14, 2023 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant