Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Appointment): create lead notes as child table #32061

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

sagarvora
Copy link
Collaborator

@sagarvora sagarvora commented Sep 2, 2022

Due to #31311
Closes #31675

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #32061 (875ff15) into develop (1c38554) will increase coverage by 0.00%.
The diff coverage is 46.37%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #32061   +/-   ##
========================================
  Coverage    63.42%   63.42%           
========================================
  Files          813      813           
  Lines        57607    57612    +5     
========================================
+ Hits         36535    36542    +7     
+ Misses       21072    21070    -2     
Impacted Files Coverage Δ
erpnext/accounts/utils.py 72.63% <ø> (ø)
erpnext/controllers/taxes_and_totals.py 95.71% <0.00%> (ø)
...ype/loan_interest_accrual/loan_interest_accrual.py 92.59% <ø> (ø)
erpnext/templates/pages/product_search.py 0.00% <0.00%> (ø)
erpnext/stock/doctype/stock_entry/stock_entry.py 81.07% <10.00%> (ø)
erpnext/e_commerce/redisearch_utils.py 35.91% <25.00%> (ø)
.../report/accounts_receivable/accounts_receivable.py 72.21% <66.66%> (ø)
...cial_statement/consolidated_financial_statement.py 89.50% <75.00%> (-0.22%) ⬇️
erpnext/crm/doctype/appointment/appointment.py 76.76% <100.00%> (+18.90%) ⬆️
...anagement/doctype/loan_repayment/loan_repayment.py 88.34% <100.00%> (ø)
... and 40 more

@sagarvora sagarvora removed the needs-tests This PR needs automated unit-tests. label Sep 2, 2022
@nabinhait nabinhait merged commit 57257a1 into frappe:develop Sep 5, 2022
@nabinhait
Copy link
Member

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2022

backport version-14-hotfix

✅ Backports have been created

@sagarvora sagarvora deleted the fix-appointment-creation branch September 5, 2022 07:03
nabinhait added a commit that referenced this pull request Sep 5, 2022
…-32061

fix(Appointment): create lead notes as child table (backport #32061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not confirm appointment
2 participants