Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SCO Supplied Items returned-qty #32128

Merged

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 8, 2022

Problem: Subcontracting Order Supplied Items Returned Qty not getting updated on submit of Stock Entry (Return of Components).

Occurred after: #32106

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #32128 (61110db) into develop (72d5366) will decrease coverage by 0.27%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32128      +/-   ##
===========================================
- Coverage    63.57%   63.30%   -0.28%     
===========================================
  Files          813      813              
  Lines        57707    57707              
===========================================
- Hits         36689    36531     -158     
- Misses       21018    21176     +158     
Impacted Files Coverage Δ
erpnext/controllers/subcontracting_controller.py 86.72% <ø> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-42.77%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-19.81%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 50.45% <0.00%> (-10.46%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 89.74% <0.00%> (-7.70%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
...next/accounts/doctype/bank_account/bank_account.py 77.27% <0.00%> (-2.28%) ⬇️
... and 26 more

@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Sep 8, 2022
@s-aga-r s-aga-r force-pushed the fix/subcontracting-order/returned-qty branch from 1f197c3 to 4f77806 Compare September 8, 2022 12:24
@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Sep 8, 2022
@s-aga-r s-aga-r force-pushed the fix/subcontracting-order/returned-qty branch from 4f77806 to aea7188 Compare September 8, 2022 12:45
@s-aga-r s-aga-r marked this pull request as ready for review September 8, 2022 13:30
@s-aga-r s-aga-r merged commit 9d453c9 into frappe:develop Sep 8, 2022
s-aga-r added a commit that referenced this pull request Sep 8, 2022
…-32128

fix: SCO Supplied Items returned-qty (backport #32128)
@s-aga-r s-aga-r added bug and removed backport version-14-hotfix backport to version 14 labels Sep 21, 2022
@s-aga-r s-aga-r deleted the fix/subcontracting-order/returned-qty branch April 15, 2023 09:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant