Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minor): delete linked payment ledger entries on source doc deletion #32137

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Sep 8, 2022

With 'Delete Accounting and Stock Ledger Entries on deletion of Transaction' toggled in Account settings and upon deletion of source document, corresponding Payment Ledger Entries should be deleted.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #32137 (70313df) into develop (3c055f9) will increase coverage by 0.49%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32137      +/-   ##
===========================================
+ Coverage    63.22%   63.72%   +0.49%     
===========================================
  Files          813      813              
  Lines        57619    57721     +102     
===========================================
+ Hits         36429    36782     +353     
+ Misses       21190    20939     -251     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 84.71% <0.00%> (-0.13%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.15% <0.00%> (-3.83%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 84.65% <0.00%> (-3.26%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 85.23% <0.00%> (-2.69%) ⬇️
...e/subcontracting_receipt/subcontracting_receipt.py 92.89% <0.00%> (-2.68%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.74% <0.00%> (-1.86%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 49.25% <0.00%> (-1.50%) ⬇️
... and 40 more

@ruthra-kumar ruthra-kumar changed the title refactor(minor): delete linked payment ledger entries no source doc deletion refactor(minor): delete linked payment ledger entries on source doc deletion Sep 10, 2022
@ruthra-kumar ruthra-kumar force-pushed the delete_payment_ledger_entries_on_src_doc_delete branch from 1afa4d6 to 70313df Compare September 10, 2022 04:01
@ruthra-kumar ruthra-kumar merged commit 4576c1e into frappe:develop Sep 11, 2022
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2022

backport version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Sep 11, 2022
…-32137

refactor(minor): delete linked payment ledger entries on source doc deletion (backport #32137)
@ruthra-kumar ruthra-kumar deleted the delete_payment_ledger_entries_on_src_doc_delete branch June 14, 2023 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant