Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rate for internal PI have non stock UOM items #32144

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Sep 9, 2022

For Internal transfers within the same company, the net rate was fetched incorrectly for Purchase Invoices.

For Eg, Lets an internal Sales Invoice is made for Item A with UOM "Kg" for 1 Kg having the stock UOM as grams
while making an internal Purchase Invoice against that SI the rate for the Item is fetched from the corresponding SI items
internal_rate field. The internal_rate is maintained in stock UOM and making a PI in non-stock UOM fetched an incorrect rate as the conversion factor was not considered.

This PR fixes that issue

@github-actions github-actions bot added buying needs-tests This PR needs automated unit-tests. labels Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #32144 (0f655e4) into develop (9e0e308) will increase coverage by 0.57%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32144      +/-   ##
===========================================
+ Coverage    63.20%   63.77%   +0.57%     
===========================================
  Files          813      813              
  Lines        57602    57713     +111     
===========================================
+ Hits         36405    36809     +404     
+ Misses       21197    20904     -293     
Impacted Files Coverage Δ
erpnext/controllers/buying_controller.py 84.25% <100.00%> (+0.25%) ⬆️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 77.62% <0.00%> (-3.50%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.79% <0.00%> (-3.19%) ⬇️
...e/subcontracting_receipt/subcontracting_receipt.py 92.89% <0.00%> (-2.68%) ⬇️
erpnext/portal/utils.py 27.69% <0.00%> (-1.54%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 49.25% <0.00%> (-1.50%) ⬇️
...t/accounts/report/sales_register/sales_register.py 80.70% <0.00%> (-1.17%) ⬇️
... and 45 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2022

backport version-13-hotfix version-14-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Sep 13, 2022
…-32144

fix: Rate for internal PI have non stock UOM items (backport #32144)
deepeshgarg007 added a commit that referenced this pull request Sep 13, 2022
…-32144

fix: Rate for internal PI have non stock UOM items (backport #32144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buying needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant