Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate Subcontracting Order Status in Stock Entry #32145

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 9, 2022

Problem: Allowed to create Stock Entry of type Send to Subcontractor or Material Transfer with the reference of a Closed Subcontracting Order.

Steps to replicate:

  1. Create Subcontract Purchase Order.
  2. Create Subcontracting Order.
  3. Transfer the Raw-Materials to the Subcontractor.
  4. Create Subcontracting Receipt (Partial).
  5. Create Stock Entry of type Material Transfer (Return of Components [Partial]), Subcontracting Order status changed to Closed.
  6. Create Stock Entry of type Send to Subcontractor or Material Transfer with Subcontracting Order reference.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 9, 2022
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Sep 9, 2022
@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #32145 (2e314a2) into develop (659d007) will decrease coverage by 0.09%.
The diff coverage is 83.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32145      +/-   ##
===========================================
- Coverage    63.59%   63.50%   -0.10%     
===========================================
  Files          813      813              
  Lines        57713    57719       +6     
===========================================
- Hits         36705    36654      -51     
- Misses       21008    21065      +57     
Impacted Files Coverage Δ
erpnext/stock/doctype/stock_entry/stock_entry.py 81.07% <83.33%> (+0.01%) ⬆️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-42.77%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-19.81%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 89.74% <0.00%> (-7.70%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 84.65% <0.00%> (-3.26%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.15% <0.00%> (-3.19%) ⬇️
... and 30 more

@s-aga-r s-aga-r marked this pull request as ready for review September 9, 2022 09:25
@s-aga-r s-aga-r merged commit 1dce3c9 into frappe:develop Sep 9, 2022
s-aga-r added a commit that referenced this pull request Sep 9, 2022
…-32145

fix: validate Subcontracting Order Status in Stock Entry (backport #32145)
@s-aga-r s-aga-r added bug and removed backport version-14-hotfix backport to version 14 labels Sep 21, 2022
@s-aga-r s-aga-r deleted the fix/stock-entry/sco branch April 15, 2023 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant