Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate call to ple creation #32156

Merged

Conversation

ruthra-kumar
Copy link
Member

Remove duplicate call for PLE creation on reverse gl creation event.

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Sep 11, 2022
@ruthra-kumar ruthra-kumar changed the title fix: remove multiple call to ple creation fix: remove duplicate call to ple creation Sep 11, 2022
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #32156 (4adc372) into develop (3c055f9) will increase coverage by 0.29%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32156      +/-   ##
===========================================
+ Coverage    63.22%   63.51%   +0.29%     
===========================================
  Files          813      813              
  Lines        57619    57725     +106     
===========================================
+ Hits         36429    36664     +235     
+ Misses       21190    21061     -129     
Impacted Files Coverage Δ
erpnext/accounts/general_ledger.py 95.00% <ø> (-0.02%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...work_order_stock_report/work_order_stock_report.py 47.50% <0.00%> (-3.93%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 77.62% <0.00%> (-3.50%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 84.65% <0.00%> (-3.26%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.79% <0.00%> (-3.19%) ⬇️
...e/subcontracting_receipt/subcontracting_receipt.py 92.89% <0.00%> (-2.68%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 49.25% <0.00%> (-1.50%) ⬇️
erpnext/support/doctype/issue/issue.py 64.28% <0.00%> (-0.96%) ⬇️
... and 35 more

@ruthra-kumar ruthra-kumar marked this pull request as ready for review September 11, 2022 06:48
@ruthra-kumar ruthra-kumar merged commit 0aeb7c6 into frappe:develop Sep 11, 2022
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2022

backport version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Sep 11, 2022
…-32156

fix: remove duplicate call to ple creation (backport #32156)
@ruthra-kumar ruthra-kumar deleted the bug_multiple_call_to_ple_creation branch June 14, 2023 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant