refactor: rewrite Production Plan queries in QB #32233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-aga-r
added
backport version-14-hotfix
s-aga-r
added a commit
that referenced
this pull request
Sep 16, 2022
…-32233 refactor: rewrite Production Plan queries in QB (backport #32233)
s-aga-r
added a commit
that referenced
this pull request
Sep 16, 2022
…-32233 refactor: rewrite Production Plan queries in QB (backport #32233)
s-aga-r
added
refactor
and removed
backport version-13-hotfix
backport version-14-hotfix
shreyanshj
reviewed
Dec 29, 2022
There was a problem hiding this comment.
In our environment, with this patch (QB update), the Sales Order Items being fetched are not excluding those Sales Order Items which don't have a default BoM. This leads to a warning about a particular Sales Order Item not having a BoM and the fetching fails. When this patch is removed, the behavior falls back to normal. And being only a restructuring, the functional impact isn't much.
I don't have sufficient method to recreate (as I have a customer owned data) - so, just a note if someone observes something similar.
(I will try to isolate to exact line and update when possible)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32735