Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch description only if empty on the payment schedule #32235

Merged

Conversation

maharshivpatel
Copy link
Contributor

added fetch_if_empty on the description field of payment_schedule.

BEFORE :

BEFORE.mov

AFTER :

AFTER.mov

added fetch_if_empty on description field of payment_schedule.
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #32235 (f4b6468) into develop (487d825) will increase coverage by 0.35%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32235      +/-   ##
===========================================
+ Coverage    63.71%   64.07%   +0.35%     
===========================================
  Files          816      816              
  Lines        58103    58103              
===========================================
+ Hits         37020    37229     +209     
+ Misses       21083    20874     -209     
Impacted Files Coverage Δ
...pnext/accounts/report/gross_profit/gross_profit.py 70.65% <0.00%> (-4.35%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
erpnext/accounts/doctype/pricing_rule/utils.py 69.84% <0.00%> (-0.52%) ⬇️
erpnext/projects/doctype/project/project.py 50.98% <0.00%> (-0.33%) ⬇️
erpnext/stock/doctype/serial_no/serial_no.py 88.99% <0.00%> (-0.24%) ⬇️
...t/accounts/report/general_ledger/general_ledger.py 67.91% <0.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.87% <0.00%> (+0.08%) ⬆️
erpnext/stock/get_item_details.py 80.35% <0.00%> (+0.14%) ⬆️
erpnext/accounts/report/financial_statements.py 33.33% <0.00%> (+0.38%) ⬆️
...xt/e_commerce/doctype/website_item/website_item.py 48.77% <0.00%> (+0.40%) ⬆️
... and 18 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2022

backport version-14-hotfix version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Sep 20, 2022
…-32235

fix: fetch description only if empty on the payment schedule (backport #32235)
deepeshgarg007 added a commit that referenced this pull request Sep 20, 2022
…-32235

fix: fetch description only if empty on the payment schedule (backport #32235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants