Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make po_detail or sco_rm_detail mandatory for SE Send to Subcontractor #32250

Merged

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 17, 2022

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 17, 2022
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Sep 17, 2022
@s-aga-r s-aga-r closed this Sep 18, 2022
@s-aga-r s-aga-r reopened this Sep 18, 2022
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 18, 2022
@s-aga-r s-aga-r force-pushed the fix/stock-entry/supplied-item-reference branch from 7f2fef9 to b908755 Compare September 18, 2022 06:07
@s-aga-r s-aga-r added backport version-14-hotfix backport to version 14 backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #32250 (b747d9d) into develop (3b5284e) will increase coverage by 0.46%.
The diff coverage is 50.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32250      +/-   ##
===========================================
+ Coverage    63.75%   64.21%   +0.46%     
===========================================
  Files          816      816              
  Lines        58116    58118       +2     
===========================================
+ Hits         37050    37320     +270     
+ Misses       21066    20798     -268     
Impacted Files Coverage Δ
erpnext/stock/doctype/stock_entry/stock_entry.py 81.02% <50.00%> (-0.05%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 65.15% <0.00%> (-0.76%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.87% <0.00%> (+0.08%) ⬆️
erpnext/stock/get_item_details.py 80.35% <0.00%> (+0.14%) ⬆️
erpnext/accounts/party.py 82.17% <0.00%> (+0.27%) ⬆️
erpnext/projects/doctype/project/project.py 51.30% <0.00%> (+0.32%) ⬆️
erpnext/accounts/report/financial_statements.py 33.33% <0.00%> (+0.38%) ⬆️
erpnext/accounts/doctype/pricing_rule/utils.py 73.67% <0.00%> (+0.50%) ⬆️
erpnext/stock/doctype/batch/batch.py 83.95% <0.00%> (+0.61%) ⬆️
.../report/accounts_receivable/accounts_receivable.py 72.21% <0.00%> (+0.65%) ⬆️
... and 31 more

@s-aga-r s-aga-r marked this pull request as ready for review September 18, 2022 09:24
@s-aga-r s-aga-r merged commit b944849 into frappe:develop Sep 18, 2022
s-aga-r added a commit that referenced this pull request Sep 18, 2022
…-32250

fix: make `po_detail` or `sco_rm_detail` mandatory for SE Send to Subcontractor (backport #32250)
s-aga-r added a commit that referenced this pull request Sep 19, 2022
…-32250

fix: make `po_detail` or `sco_rm_detail` mandatory for SE Send to Subcontractor (backport #32250)
@s-aga-r s-aga-r deleted the fix/stock-entry/supplied-item-reference branch April 15, 2023 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant