-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use default supplier currency if default supplier is enabled #32251
Merged
ruthra-kumar
merged 1 commit into
frappe:develop
from
ruthra-kumar:set_default_supplier_currency_for_po_created_from_so
Sep 19, 2022
Merged
fix: use default supplier currency if default supplier is enabled #32251
ruthra-kumar
merged 1 commit into
frappe:develop
from
ruthra-kumar:set_default_supplier_currency_for_po_created_from_so
Sep 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32251 +/- ##
===========================================
+ Coverage 63.50% 64.20% +0.69%
===========================================
Files 813 816 +3
Lines 57708 58120 +412
===========================================
+ Hits 36650 37318 +668
+ Misses 21058 20802 -256
|
@Mergifyio backport version-12-hotfix |
❌ No backport have been created
|
✅ Backports have been created
|
@Mergifyio backport version-13-hotfix version-14-hotfix |
This was referenced Sep 19, 2022
✅ Backports have been created
|
ruthra-kumar
added a commit
that referenced
this pull request
Sep 19, 2022
…-32251 fix: use default supplier currency if default supplier is enabled (backport #32251)
deepeshgarg007
added a commit
that referenced
this pull request
Sep 19, 2022
…-32251 fix: use default supplier currency if default supplier is enabled (backport #32251)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating Purchase Order from Sales Order, if default Supplier is provided, use Supplier currency as the transaction currency for the Sales Order.
![Screenshot 2022-09-17 at 4 37 10 PM](https://user-images.githubusercontent.com/3272205/190853818-06ab56b4-e4c3-4056-abf6-95268f8872ae.png)
2. Supplier billing currency.![Screenshot 2022-09-17 at 4 40 51 PM](https://user-images.githubusercontent.com/3272205/190853825-8abcee76-15e8-49c8-a82a-abfa3a225f62.png)
3. Create Purchase Order.Old behaviour:
Purchase Order created in Sales Order currency.
![Screenshot 2022-09-17 at 4 42 51 PM](https://user-images.githubusercontent.com/3272205/190853872-8c36b23c-198b-4c1f-9b0b-84549e06eb15.png)
New behaviour:
Purchase Order created in Supplier currency.![Screenshot 2022-09-17 at 4 43 19 PM](https://user-images.githubusercontent.com/3272205/190853878-fa8c832e-304c-45e7-a9bb-9ed2a32a813e.png)