Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default supplier currency if default supplier is enabled #32251

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Sep 17, 2022

While creating Purchase Order from Sales Order, if default Supplier is provided, use Supplier currency as the transaction currency for the Sales Order.

  1. Sales Order item with Supplier.

Screenshot 2022-09-17 at 4 36 53 PM

Screenshot 2022-09-17 at 4 37 10 PM

2. Supplier billing currency.

Screenshot 2022-09-17 at 4 40 51 PM

3. Create Purchase Order.

Screenshot 2022-09-17 at 4 42 19 PM

Old behaviour:

Purchase Order created in Sales Order currency.
Screenshot 2022-09-17 at 4 42 51 PM

New behaviour:

Purchase Order created in Supplier currency. Screenshot 2022-09-17 at 4 43 19 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 17, 2022
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #32251 (77fdc37) into develop (8f787c0) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32251      +/-   ##
===========================================
+ Coverage    63.50%   64.20%   +0.69%     
===========================================
  Files          813      816       +3     
  Lines        57708    58120     +412     
===========================================
+ Hits         36650    37318     +668     
+ Misses       21058    20802     -256     
Impacted Files Coverage Δ
erpnext/selling/doctype/sales_order/sales_order.py 79.96% <100.00%> (+0.14%) ⬆️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 89.74% <0.00%> (-7.70%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 86.66% <0.00%> (-1.26%) ⬇️
erpnext/support/doctype/issue/issue.py 64.28% <0.00%> (-0.96%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 65.15% <0.00%> (-0.76%) ⬇️
...cturing/doctype/production_plan/production_plan.py 74.50% <0.00%> (-0.54%) ⬇️
...service_level_agreement/service_level_agreement.py 83.14% <0.00%> (-0.15%) ⬇️
erpnext/projects/doctype/project/project.py 51.30% <0.00%> (-0.15%) ⬇️
erpnext/controllers/accounts_controller.py 84.36% <0.00%> (-0.13%) ⬇️
erpnext/setup/doctype/company/company.py 73.50% <0.00%> (ø)
... and 49 more

@ruthra-kumar ruthra-kumar marked this pull request as ready for review September 19, 2022 05:14
@ruthra-kumar ruthra-kumar merged commit efc9553 into frappe:develop Sep 19, 2022
@ruthra-kumar
Copy link
Member Author

ruthra-kumar commented Sep 19, 2022

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2022

backport @version-12-hotfix

❌ No backport have been created

  • Backport to branch @version-12-hotfix failed: Branch not found

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2022

backport version-12-hotfix

✅ Backports have been created

@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-13-hotfix version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2022

backport version-13-hotfix version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Sep 19, 2022
…-32251

fix: use default supplier currency if default supplier is enabled (backport #32251)
deepeshgarg007 added a commit that referenced this pull request Sep 19, 2022
…-32251

fix: use default supplier currency if default supplier is enabled (backport #32251)
@ruthra-kumar ruthra-kumar deleted the set_default_supplier_currency_for_po_created_from_so branch June 14, 2023 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant