Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite Item Shortage Report queries in QB #32280

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 20, 2022

ref: ISS-22-23-02434

#32735

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #32280 (dad40b8) into develop (377576f) will increase coverage by 0.15%.
The diff coverage is 62.06%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32280      +/-   ##
===========================================
+ Coverage    63.93%   64.08%   +0.15%     
===========================================
  Files          816      816              
  Lines        58112    58121       +9     
===========================================
+ Hits         37153    37246      +93     
+ Misses       20959    20875      -84     
Impacted Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 72.79% <38.88%> (-0.56%) ⬇️
...eport/item_shortage_report/item_shortage_report.py 93.54% <100.00%> (+93.54%) ⬆️
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-31.15%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
.../fifo_queue_vs_qty_after_transaction_comparison.py 93.10% <0.00%> (-1.73%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 86.84% <0.00%> (-1.32%) ⬇️
erpnext/assets/doctype/asset/asset.py 81.92% <0.00%> (-0.83%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 76.87% <0.00%> (-0.69%) ⬇️
erpnext/stock/doctype/batch/batch.py 83.33% <0.00%> (-0.62%) ⬇️
... and 23 more

@s-aga-r s-aga-r removed dont-merge needs-tests This PR needs automated unit-tests. labels Sep 20, 2022
@s-aga-r s-aga-r force-pushed the refactor/report/item-shortage-report branch from b424c18 to 3dc754c Compare September 20, 2022 05:18
@s-aga-r s-aga-r changed the title refactor: rewrite Item Shortage Report queries in QB refactor: rewrite Item Shortage Report queries in QB Sep 20, 2022
@s-aga-r s-aga-r marked this pull request as ready for review September 20, 2022 05:44
@s-aga-r s-aga-r merged commit 2186a89 into frappe:develop Sep 20, 2022
s-aga-r added a commit that referenced this pull request Sep 20, 2022
…-32280

refactor: rewrite `Item Shortage Report` queries in QB (backport #32280)
s-aga-r added a commit that referenced this pull request Sep 20, 2022
…-32280

refactor: rewrite `Item Shortage Report` queries in QB (backport #32280)
@s-aga-r s-aga-r deleted the refactor/report/item-shortage-report branch April 15, 2023 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant