Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite BOM Stock Report queries in QB #32295

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 20, 2022

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 20, 2022
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #32295 (92e03e2) into develop (6e65f01) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32295      +/-   ##
===========================================
- Coverage    64.07%   64.06%   -0.01%     
===========================================
  Files          817      817              
  Lines        58126    58129       +3     
===========================================
  Hits         37243    37243              
- Misses       20883    20886       +3     
Impacted Files Coverage Δ
...eport/bom_stock_calculated/bom_stock_calculated.py 88.63% <0.00%> (ø)
...turing/report/bom_stock_report/bom_stock_report.py 87.09% <85.71%> (+4.95%) ⬆️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-11.63%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 84.65% <0.00%> (-3.73%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 86.32% <0.00%> (-3.42%) ⬇️
erpnext/utilities/activation.py 62.85% <0.00%> (-2.86%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-1.76%) ⬇️
...cial_statement/consolidated_financial_statement.py 89.50% <0.00%> (-0.93%) ⬇️
erpnext/accounts/party.py 81.61% <0.00%> (-0.56%) ⬇️
erpnext/accounts/report/financial_statements.py 32.95% <0.00%> (-0.39%) ⬇️
... and 16 more

@s-aga-r s-aga-r marked this pull request as ready for review September 20, 2022 17:36
@s-aga-r s-aga-r merged commit 2235f31 into frappe:develop Sep 20, 2022
s-aga-r added a commit that referenced this pull request Sep 20, 2022
…-32295

refactor: rewrite `BOM Stock Report` queries in `QB` (backport #32295)
s-aga-r added a commit that referenced this pull request Sep 20, 2022
…-32295

refactor: rewrite `BOM Stock Report` queries in `QB` (backport #32295)
@s-aga-r s-aga-r deleted the refactor/report/bom-stock-report branch April 15, 2023 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant