Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: total value in all keys #32310

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

nishibakabeer
Copy link
Contributor

@nishibakabeer nishibakabeer commented Sep 21, 2022

Gross and net profit report showing wrong values in monthly quarterly and half yearly filters which is the total value @ruthra-kumar added in develop branch as suggested ( #32020)

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 21, 2022
@ruthra-kumar ruthra-kumar self-assigned this Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #32310 (6919f38) into develop (07f87b9) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32310      +/-   ##
===========================================
+ Coverage    63.90%   63.99%   +0.08%     
===========================================
  Files          817      817              
  Lines        58129    58153      +24     
===========================================
+ Hits         37150    37216      +66     
+ Misses       20979    20937      -42     
Impacted Files Coverage Δ
...d_net_profit_report/gross_and_net_profit_report.py 0.00% <ø> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-11.63%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 84.65% <0.00%> (-3.73%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 86.32% <0.00%> (-3.42%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.79% <0.00%> (-2.55%) ⬇️
... and 30 more

Gross and net profit report showing wrong values in monthly quarterly and half yearly filters which is the total value
@ruthra-kumar added in develop branch as suggested ( frappe#32020)
@ruthra-kumar ruthra-kumar changed the title fix:total value in all keys fix: total value in all keys Sep 26, 2022
@ruthra-kumar ruthra-kumar merged commit 8b21d27 into frappe:develop Sep 26, 2022
@ruthra-kumar
Copy link
Member

@Mergifyio backport version-13-hotfix version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

backport version-13-hotfix version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Sep 26, 2022
…-32310

fix: total value in all keys (backport #32310)
ruthra-kumar added a commit that referenced this pull request Sep 26, 2022
…-32310

fix: total value in all keys (backport #32310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants