Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opening entry causing discrepancy between stock and trial balance #32339

Conversation

rohitwaghchaure
Copy link
Collaborator

If the stock entry has Is Opening yes then it shows the stock entry amount even though before the posting date in the General Ledger and Trial Balance report but in the stock balance the amount reflects as per the Posting Date. This causing the discrepancy between Stock Balance and Trial Balance report for specific dates.

For example

If the Stock Entry has made on 5th July 2022 with amount as 1000 and user has checking Trial Balance report for a month April 2022. Then trial balance will show the opening amount as 1000 but if you check the stock balance for the same period then the balance would show zero.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #32339 (bc3ab45) into develop (1f49329) will decrease coverage by 0.28%.
The diff coverage is 45.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32339      +/-   ##
===========================================
- Coverage    64.11%   63.83%   -0.29%     
===========================================
  Files          817      817              
  Lines        58117    58145      +28     
===========================================
- Hits         37263    37115     -148     
- Misses       20854    21030     +176     
Impacted Files Coverage Δ
...ext/accounts/report/trial_balance/trial_balance.py 0.00% <ø> (ø)
...trial_balance_for_party/trial_balance_for_party.py 0.00% <ø> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 72.79% <38.88%> (-0.56%) ⬇️
...t/accounts/report/general_ledger/general_ledger.py 67.91% <100.00%> (-0.35%) ⬇️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-42.77%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-19.81%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
... and 36 more

@rohitwaghchaure rohitwaghchaure merged commit 106ee1b into frappe:develop Sep 26, 2022
rohitwaghchaure added a commit that referenced this pull request Sep 27, 2022
…-32339

fix: opening entry causing discrepancy between stock and trial balance (backport #32339)
rohitwaghchaure added a commit that referenced this pull request Sep 27, 2022
…-32339

fix: opening entry causing discrepancy between stock and trial balance (backport #32339)
rohitwaghchaure added a commit to rohitwaghchaure/erpnext_develop that referenced this pull request Sep 27, 2022
…try-trial-balance-issue

fix: opening entry causing discrepancy between stock and trial balance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant