Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not allowing to return expired batches using purchase return #32370

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Sep 27, 2022

Issue
System was not allowing to make purchase return entry against expired batch by throwing below validation

Screenshot 2022-09-27 at 11 52 32 AM

After Fix

User will be able to create purchase invoice return or purchase receipt return against the expired batch.

@rohitwaghchaure rohitwaghchaure force-pushed the fixed-allow-expied-batch-return-using-pr-pi branch from fee2a6c to a4a86ee Compare September 27, 2022 08:26
@rohitwaghchaure rohitwaghchaure changed the title fix: allow to return expired batches using purchase return fix: Not allowing to return expired batches using purchase return Sep 27, 2022
@mujeerhashmi
Copy link
Contributor

Backport needed.

@rohitwaghchaure
Copy link
Collaborator Author

rohitwaghchaure commented Sep 27, 2022

Backport needed.

Added labels already, these labels will create backport PRs

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #32370 (a4a86ee) into develop (106ee1b) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32370      +/-   ##
===========================================
+ Coverage    63.94%   64.09%   +0.15%     
===========================================
  Files          817      817              
  Lines        58159    58161       +2     
===========================================
+ Hits         37190    37281      +91     
+ Misses       20969    20880      -89     
Impacted Files Coverage Δ
...k/doctype/stock_ledger_entry/stock_ledger_entry.py 83.89% <100.00%> (+0.27%) ⬆️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 88.88% <0.00%> (-3.71%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 86.32% <0.00%> (-3.42%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 73.24% <0.00%> (-2.71%) ⬇️
erpnext/stock/doctype/item_price/item_price.py 92.98% <0.00%> (-1.76%) ⬇️
erpnext/stock/reorder_item.py 73.33% <0.00%> (-1.67%) ⬇️
... and 16 more

@rohitwaghchaure rohitwaghchaure merged commit c917d71 into frappe:develop Sep 27, 2022
rohitwaghchaure added a commit that referenced this pull request Sep 27, 2022
…-32370

fix: Not allowing to return expired batches using purchase return (backport #32370)
rohitwaghchaure added a commit that referenced this pull request Sep 27, 2022
…-32370

fix: Not allowing to return expired batches using purchase return (backport #32370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants