-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Not allowing to return expired batches using purchase return #32370
Merged
rohitwaghchaure
merged 1 commit into
frappe:develop
from
rohitwaghchaure:fixed-allow-expied-batch-return-using-pr-pi
Sep 27, 2022
Merged
fix: Not allowing to return expired batches using purchase return #32370
rohitwaghchaure
merged 1 commit into
frappe:develop
from
rohitwaghchaure:fixed-allow-expied-batch-return-using-pr-pi
Sep 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fee2a6c
to
a4a86ee
Compare
Backport needed. |
Added labels already, these labels will create backport PRs |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32370 +/- ##
===========================================
+ Coverage 63.94% 64.09% +0.15%
===========================================
Files 817 817
Lines 58159 58161 +2
===========================================
+ Hits 37190 37281 +91
+ Misses 20969 20880 -89
|
This was referenced Sep 27, 2022
rohitwaghchaure
added a commit
that referenced
this pull request
Sep 27, 2022
…-32370 fix: Not allowing to return expired batches using purchase return (backport #32370)
rohitwaghchaure
added a commit
that referenced
this pull request
Sep 27, 2022
…-32370 fix: Not allowing to return expired batches using purchase return (backport #32370)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
System was not allowing to make purchase return entry against expired batch by throwing below validation
After Fix
User will be able to create purchase invoice return or purchase receipt return against the expired batch.