Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disbursement Account in patch to update old loans #32403

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

deepeshgarg007
Copy link
Member

File "/home/frappe/frappe-bench/apps/erpnext/erpnext/patches/v13_0/update_old_loans.py", line 130, in execute
    loan_type_doc.submit()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1018, in submit
    return self._submit()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1007, in _submit
    return self.save()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 310, in save
    return self._save(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 350, in _save
    self._validate()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 538, in _validate
    self._validate_mandatory()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 891, in _validate_mandatory
    fields=", ".join((each[0] for each in missing)), doctype=self.doctype, name=self.name
frappe.exceptions.MandatoryError: [Loan Type, vale]: disbursement_account

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #32403 (be623ce) into develop (106ee1b) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32403      +/-   ##
===========================================
- Coverage    63.94%   63.85%   -0.09%     
===========================================
  Files          817      817              
  Lines        58159    58179      +20     
===========================================
- Hits         37190    37153      -37     
- Misses       20969    21026      +57     
Impacted Files Coverage Δ
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
erpnext/accounts/party.py 77.71% <0.00%> (-4.18%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 86.32% <0.00%> (-3.42%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 73.24% <0.00%> (-2.71%) ⬇️
erpnext/stock/reorder_item.py 73.33% <0.00%> (-1.67%) ⬇️
erpnext/support/doctype/issue/issue.py 64.28% <0.00%> (-0.96%) ⬇️
... and 17 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

backport version-13-hotfix version-14-hotfix

✅ Backports have been created

@deepeshgarg007 deepeshgarg007 merged commit 84ab5d4 into frappe:develop Sep 28, 2022
deepeshgarg007 added a commit that referenced this pull request Sep 28, 2022
…-32403

fix: Disbursement Account in patch to update old loans (backport #32403)
deepeshgarg007 added a commit that referenced this pull request Sep 28, 2022
…-32403

fix: Disbursement Account in patch to update old loans (backport #32403)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant