Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supplied items added twice in Stock Entry #32406

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 28, 2022

ref: ISS-22-23-02579

1

2

Problem: Supplied Items added twice while creating Stock Entry of type Send to Subcontractor with Purchase Order reference i.e., Old Subcontracting Flow

#32274

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 28, 2022
@s-aga-r s-aga-r added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #32406 (a145d10) into develop (dde8b2a) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32406      +/-   ##
===========================================
- Coverage    63.88%   63.76%   -0.13%     
===========================================
  Files          817      817              
  Lines        58179    58179              
===========================================
- Hits         37170    37099      -71     
- Misses       21009    21080      +71     
Impacted Files Coverage Δ
erpnext/controllers/subcontracting_controller.py 86.34% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-11.63%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 84.65% <0.00%> (-3.73%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 86.32% <0.00%> (-3.42%) ⬇️
... and 21 more

@s-aga-r s-aga-r marked this pull request as ready for review September 28, 2022 12:20
@s-aga-r s-aga-r merged commit 9743add into frappe:develop Sep 28, 2022
@s-aga-r s-aga-r added the bug label Sep 28, 2022
s-aga-r added a commit that referenced this pull request Sep 28, 2022
…-32406

fix: supplied items added twice in Stock Entry (backport #32406)
@s-aga-r s-aga-r removed the backport version-14-hotfix backport to version 14 label Sep 29, 2022
@s-aga-r s-aga-r deleted the fix/stock-entry/supplied-items branch April 15, 2023 09:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant