Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: searchfields as per customize form not working for Item #32414

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

Set item_name in the search fields for the Item doctype using customize form
Screenshot 2022-09-28 at 11 03 26 PM

Still other columns like item_group, description showing in the dropdown
Screenshot 2022-09-28 at 11 04 24 PM

After Fix
Screenshot 2022-09-28 at 10 58 40 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #32414 (3656f7d) into develop (d5359bb) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32414      +/-   ##
===========================================
- Coverage    64.00%   63.76%   -0.25%     
===========================================
  Files          817      817              
  Lines        58172    58177       +5     
===========================================
- Hits         37232    37095     -137     
- Misses       20940    21082     +142     
Impacted Files Coverage Δ
erpnext/controllers/queries.py 62.84% <100.00%> (-0.26%) ⬇️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-31.15%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-23.73%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-11.63%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 50.88% <0.00%> (-11.51%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-8.19%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
...ck/report/cogs_by_item_group/cogs_by_item_group.py 86.32% <0.00%> (-3.42%) ⬇️
... and 25 more

@rohitwaghchaure rohitwaghchaure removed the needs-tests This PR needs automated unit-tests. label Sep 29, 2022
@rohitwaghchaure rohitwaghchaure merged commit 10b7592 into frappe:develop Sep 29, 2022
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Sep 29, 2022
rohitwaghchaure added a commit that referenced this pull request Sep 29, 2022
…-32414

fix: searchfields as per customize form not working for Item (backport #32414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant