Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PO cancel post advance payment cancel against PO #32536

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

deepeshgarg007
Copy link
Member

fixes: #32287

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 8, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2022

backport version-13-hotfix version-14-hotfix

✅ Backports have been created

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #32536 (d806e32) into develop (73a9791) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32536      +/-   ##
===========================================
- Coverage    63.84%   63.75%   -0.09%     
===========================================
  Files          817      817              
  Lines        58215    58215              
===========================================
- Hits         37167    37116      -51     
- Misses       21048    21099      +51     
Impacted Files Coverage Δ
...xt/buying/doctype/purchase_order/purchase_order.py 74.01% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-23.73%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 81.96% <0.00%> (-8.20%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 79.02% <0.00%> (-2.10%) ⬇️
.../fifo_queue_vs_qty_after_transaction_comparison.py 93.10% <0.00%> (-1.73%) ⬇️
erpnext/stock/reorder_item.py 73.33% <0.00%> (-1.67%) ⬇️
... and 17 more

@deepeshgarg007 deepeshgarg007 merged commit 0f033bf into frappe:develop Oct 9, 2022
deepeshgarg007 added a commit that referenced this pull request Oct 11, 2022
…-32536

fix: PO cancel post advance payment cancel against PO (backport #32536)
deepeshgarg007 added a commit that referenced this pull request Oct 11, 2022
…-32536

fix: PO cancel post advance payment cancel against PO (backport #32536)
@dawoodjee
Copy link
Contributor

Cannot delete or cancel because Payroll Entry HR-PRUN-2022-00015 is linked
with GL Entry ACC-GLE-2022-38178

I also had this problem when deleting Payroll Entries. Adding line 93 in the payroll_entry.py resolved it.

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete or cancel because Purchase Order is linked with GL Entry
2 participants