refactor: split ple creation function into two #32598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
accounts
needs-tests
ruthra-kumar
requested review from
nextchamp-saqib and
deepeshgarg007
as code owners
refactor create_payment_ledger_entry function into 2. one for generating ple map and one for DB entry creation
ruthra-kumar
force-pushed
the
refactor_create_payment_ledger_function
branch
from
5ba8f63
to
9b50221
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32598 +/- ##
========================================
Coverage 63.67% 63.68%
========================================
Files 816 816
Lines 58252 58260 +8
========================================
+ Hits 37093 37101 +8
Misses 21159 21159
|
|
@Mergifyio backport version-14-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Oct 18, 2022
…-32598 refactor: split ple creation function into two (backport #32598)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
create_payment_ledger_entryfunction. PLE map generation is separated out into a new function.