Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Integrity Error on PLE while submitting sales invoice #32635

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Oct 18, 2022

Avoid updating outstanding amount using PLE on Receivable/Payable Account heads that doesn't have party_type and party field value supplied.
Screenshot 2022-10-18 at 5 35 09 PM

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #32635 (8f42e7f) into develop (d794b83) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32635      +/-   ##
===========================================
+ Coverage    63.67%   63.71%   +0.03%     
===========================================
  Files          816      816              
  Lines        58252    58300      +48     
===========================================
+ Hits         37093    37145      +52     
+ Misses       21159    21155       -4     
Impacted Files Coverage Δ
erpnext/accounts/utils.py 73.30% <100.00%> (+0.31%) ⬆️
...tch_item_expiry_status/batch_item_expiry_status.py 66.66% <0.00%> (-1.26%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.00% <0.00%> (-0.79%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-0.54%) ⬇️
...ounts/doctype/purchase_invoice/purchase_invoice.py 83.83% <0.00%> (ø)
...purchase_order_analysis/purchase_order_analysis.py 0.00% <0.00%> (ø)
...tation_comparison/supplier_quotation_comparison.py 0.00% <0.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.90% <0.00%> (+0.08%) ⬆️
erpnext/accounts/doctype/gl_entry/gl_entry.py 69.10% <0.00%> (+0.52%) ⬆️
... and 6 more

@ruthra-kumar ruthra-kumar marked this pull request as ready for review October 19, 2022 03:16
@ruthra-kumar ruthra-kumar merged commit f844097 into frappe:develop Oct 19, 2022
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2022

backport version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Oct 21, 2022
…-32635

fix: Integrity Error on PLE while submitting sales invoice (backport #32635)
@ruthra-kumar ruthra-kumar deleted the fix_tax_or_charges_acc_updating_voucher_outstanding branch June 14, 2023 16:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant