Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overlap error not raised for job card in case of workstation with production capacity #32645

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  • Set production capacity as 3 in the workstation and created 4 Work Order against the same workstation
  • Set "Planned Start Date" same to all 4 work orders and submitted
  • System has created Job Card with same time logs and not raised Overlap Error

Ideally system should consider next available time slot

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #32645 (8b2165e) into develop (f844097) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32645      +/-   ##
===========================================
- Coverage    63.72%   63.71%   -0.01%     
===========================================
  Files          816      816              
  Lines        58310    58310              
===========================================
- Hits         37156    37155       -1     
- Misses       21154    21155       +1     
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/job_card/job_card.py 71.32% <ø> (+0.23%) ⬆️
erpnext/stock/stock_ledger.py 89.95% <0.00%> (-0.32%) ⬇️

@rohitwaghchaure rohitwaghchaure merged commit de4c052 into frappe:develop Oct 19, 2022
rohitwaghchaure added a commit that referenced this pull request Oct 19, 2022
…-32645

fix: overlap error not raised for job card in case of workstation with production capacity (backport #32645)
rohitwaghchaure added a commit that referenced this pull request Oct 20, 2022
…-32645

fix: overlap error not raised for job card in case of workstation with production capacity (backport #32645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant