Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite stock reports queries in qb #32662

Merged
merged 5 commits into from
Oct 28, 2022
Merged

refactor: rewrite stock reports queries in qb #32662

merged 5 commits into from
Oct 28, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Oct 20, 2022 •
edited
Loading

  • Stock Ledger Report
  • Product Bundle Balance Report
  • Itemwise Recommended Reorder Level Report

#32735

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 20, 2022
@s-aga-r s-aga-r added dont-merge refactor WIP and removed needs-tests This PR needs automated unit-tests. labels Oct 20, 2022
@s-aga-r s-aga-r force-pushed the refactor/stock/remaining-reports branch 2 times, most recently from 3710a5c to 5a7af21 Compare October 20, 2022 06:31
@s-aga-r s-aga-r force-pushed the refactor/stock/remaining-reports branch from 8c008f1 to 5a7af21 Compare October 21, 2022 04:50
@s-aga-r s-aga-r force-pushed the refactor/stock/remaining-reports branch from 5a7af21 to ca42cec Compare October 21, 2022 07:43
@s-aga-r s-aga-r removed the WIP label Oct 21, 2022
@s-aga-r s-aga-r marked this pull request as ready for review October 21, 2022 07:43
@s-aga-r s-aga-r marked this pull request as draft October 21, 2022 08:48
@s-aga-r s-aga-r force-pushed the refactor/stock/remaining-reports branch from a125c5f to 40bd121 Compare October 21, 2022 09:24
@codecov
Copy link

codecov bot commented Oct 21, 2022 •
edited
Loading

Codecov Report

Merging #32662 (334b158) into develop (16959c0) will increase coverage by 0.01%.
The diff coverage is 89.87%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #32662      +/-   ##
===========================================
+ Coverage    63.79%   63.80%   +0.01%     
===========================================
  Files          817      817              
  Lines        58453    58475      +22     
===========================================
+ Hits         37290    37312      +22     
  Misses       21163    21163
Impacted Files Coverage Δ
erpnext/stock/report/stock_ledger/stock_ledger.py 75.77% <81.81%> (+1.26%) ⬆️
...t/product_bundle_balance/product_bundle_balance.py 80.21% <92.30%> (+0.67%) ⬆️
...eorder_level/itemwise_recommended_reorder_level.py 92.30% <93.54%> (+1.56%) ⬆️

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Oct 21, 2022
@s-aga-r s-aga-r marked this pull request as ready for review October 21, 2022 10:43
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix

@deepeshgarg007 deepeshgarg007 merged commit b6ade62 into frappe:develop Oct 28, 2022
@mergify mergify bot mentioned this pull request Oct 28, 2022
Closed
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2022

backport version-13-hotfix

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 28, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2022

backport version-14-hotfix

✅ Backports have been created

@s-aga-r s-aga-r removed the backport version-14-hotfix backport to version 14 label Oct 28, 2022
s-aga-r added a commit that referenced this pull request Oct 28, 2022
@s-aga-r
Merge pull request #32750 from frappe/mergify/bp/version-14-hotfix/pr…
199e77f 
…-32662

refactor: rewrite stock reports queries in qb (backport #32662)
@s-aga-r s-aga-r deleted the refactor/stock/remaining-reports branch April 15, 2023 10:01
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-aga-r @deepeshgarg007