Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Curreny in SOA print for multi-currency party #32699

Merged
merged 2 commits into from
Oct 28, 2022
Merged

fix: Curreny in SOA print for multi-currency party #32699

merged 2 commits into from
Oct 28, 2022

Conversation

deepeshgarg007
Copy link
Member

Fixes: #32400

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2022 •
edited
Loading

backport version-14-hotfix

✅ Backports have been created

maharshivpatel
maharshivpatel suggested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@maharshivpatel maharshivpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to consider when user selects currency from the filter.

erpnext/accounts/report/general_ledger/general_ledger.html Outdated Show resolved Hide resolved
erpnext/accounts/report/general_ledger/general_ledger.html Outdated Show resolved Hide resolved
erpnext/accounts/report/general_ledger/general_ledger.html Outdated Show resolved Hide resolved
erpnext/accounts/report/general_ledger/general_ledger.html Outdated Show resolved Hide resolved
erpnext/accounts/report/general_ledger/general_ledger.html Outdated Show resolved Hide resolved
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 9ac1c4b into frappe:develop Oct 28, 2022
@mergify mergify bot mentioned this pull request Oct 28, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2022

backport version-14-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 29, 2022
@deepeshgarg007
Merge pull request #32746 from frappe/mergify/bp/version-14-hotfix/pr…
ad6e0f3 
…-32699

fix: Curreny in SOA print for multi-currency party (backport #32699)
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maharshivpatel maharshivpatel maharshivpatel requested changes

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in General ledger print of Customer/supplier with different Currency than base
2 participants
@deepeshgarg007 @maharshivpatel