Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issues while cancel/amending Purchase Invoice with TDS enabled #32801

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Nov 1, 2022

This PR didn't fully fix the issue, a few loose ends were still left, but this PR fixes them all

  • Ignore linked invoices while canceling any old invoice
  • On amending, clear the tax_withheld_voucher_table to avoid canceled doc linking errors

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 1, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

backport version-13-hotfix version-14-hotfix

✅ Backports have been created

@deepeshgarg007 deepeshgarg007 merged commit 62ae329 into frappe:develop Nov 1, 2022
deepeshgarg007 added a commit that referenced this pull request Nov 1, 2022
…-32801

fix: Issues while cancel/amending Purchase Invoice with TDS enabled (backport #32801)
deepeshgarg007 added a commit that referenced this pull request Nov 1, 2022
…-32801

fix: Issues while cancel/amending Purchase Invoice with TDS enabled (backport #32801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant