Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update advance paid in SO/PO from Payment Ledger #32816

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Nov 2, 2022

advance_paid in Sales and Purchase Order will be calculated and updated from Payment Ledger

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #32816 (4487065) into develop (4d5ef72) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 4487065 differs from pull request most recent head 721ac6b. Consider uploading reports for the commit 721ac6b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32816      +/-   ##
===========================================
+ Coverage    63.72%   63.81%   +0.09%     
===========================================
  Files          816      817       +1     
  Lines        58314    58510     +196     
===========================================
+ Hits         37160    37338     +178     
- Misses       21154    21172      +18     
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/job_card/job_card.py 71.32% <ø> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 72.79% <100.00%> (ø)
erpnext/controllers/accounts_controller.py 84.88% <100.00%> (+0.09%) ⬆️
erpnext/controllers/taxes_and_totals.py 95.05% <0.00%> (-0.70%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.56% <0.00%> (-0.35%) ⬇️
erpnext/stock/doctype/serial_no/serial_no.py 88.96% <0.00%> (-0.24%) ⬇️
...xt/accounts/doctype/journal_entry/journal_entry.py 68.25% <0.00%> (-0.21%) ⬇️
erpnext/controllers/queries.py 62.84% <0.00%> (ø)
erpnext/selling/doctype/sales_order/sales_order.py 80.03% <0.00%> (ø)
...rpnext/assets/doctype/asset_repair/asset_repair.py 66.87% <0.00%> (ø)
... and 22 more

@ruthra-kumar ruthra-kumar marked this pull request as ready for review November 2, 2022 10:57
@ruthra-kumar ruthra-kumar merged commit c3dc1c2 into frappe:develop Nov 2, 2022
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

backport version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Nov 2, 2022
…-32816

fix: update advance paid in SO/PO from Payment Ledger (backport #32816)
@ruthra-kumar ruthra-kumar deleted the advance_paid_in_so_and_po branch June 14, 2023 16:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant