Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get consumed_qty based on received_qty in SCR #32867

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Nov 6, 2022

ref: ISS-22-23-03098

Steps to reproduce:

  • Create a Subcontracted Purchase Order.
  • Create a Subcontracting Order against that Purchase Order.
  • Create a Subcontracting Receipt against that Subcontracting Order (Set the Rejected Qty).

Problem:
The system ignores the Rejected Qty while getting the Supplied Item Consumed Qty.

Before:

Screencast.from.2022-11-06.15-03-34.webm

After:

Screencast.from.2022-11-06.15-04-15.webm

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Nov 6, 2022
@s-aga-r s-aga-r changed the title Fix/scr/rejected qty fix: get consumed_qty based on received_qty in SCR Nov 6, 2022
@s-aga-r s-aga-r changed the title fix: get consumed_qty based on received_qty in SCR fix: get consumed_qty based on received_qty in SCR Nov 6, 2022
@s-aga-r s-aga-r changed the title fix: get consumed_qty based on received_qty in SCR fix: get consumed_qty based on received_qty in SCR Nov 6, 2022
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #32867 (4d8da44) into develop (d2b6490) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32867      +/-   ##
===========================================
+ Coverage    63.84%   63.85%   +0.01%     
===========================================
  Files          817      817              
  Lines        58543    58548       +5     
===========================================
+ Hits         37374    37387      +13     
+ Misses       21169    21161       -8     
Impacted Files Coverage Δ
erpnext/controllers/subcontracting_controller.py 87.16% <100.00%> (+1.47%) ⬆️
...e/subcontracting_receipt/subcontracting_receipt.py 92.30% <100.00%> (+0.17%) ⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.56% <0.00%> (+0.08%) ⬆️

@s-aga-r s-aga-r marked this pull request as ready for review November 6, 2022 10:47
@s-aga-r s-aga-r merged commit 8859e6f into frappe:develop Nov 6, 2022
@s-aga-r s-aga-r added bug and removed backport version-14-hotfix backport to version 14 labels Nov 6, 2022
s-aga-r added a commit that referenced this pull request Nov 6, 2022
…-32867

fix: get `consumed_qty` based on `received_qty` in SCR (backport #32867)
@s-aga-r s-aga-r deleted the fix/scr/rejected-qty branch April 15, 2023 10:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant