Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect currency in Exchange rate revaluation #32999

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Nov 17, 2022

Use company currency for Base amount fields in Exchange Rate Revaluation doctype.

Companies with different default currencies.
Screenshot 2022-11-17 at 10 55 52 AM

Base currency and Account currency on respective fields:

scr1.mp4

@ruthra-kumar ruthra-kumar force-pushed the exchange_rate_reval_company_currency branch from 5acc9ff to 5caaccc Compare November 18, 2022 11:41
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #32999 (5caaccc) into develop (df09668) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32999      +/-   ##
===========================================
- Coverage    63.83%   63.83%   -0.01%     
===========================================
  Files          820      820              
  Lines        58770    58771       +1     
===========================================
  Hits         37516    37516              
- Misses       21254    21255       +1     
Impacted Files Coverage Δ
...ange_rate_revaluation/exchange_rate_revaluation.py 48.48% <0.00%> (-0.50%) ⬇️

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 26dcde2 into frappe:develop Nov 19, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2022

backport version-14-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Nov 19, 2022
…-32999

fix: incorrect currency in Exchange rate revaluation (backport #32999)
@ruthra-kumar ruthra-kumar deleted the exchange_rate_reval_company_currency branch June 14, 2023 16:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong currency symbol in "Exchange Rate Revaluation" form
2 participants