Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use list() on self mutating iteration #33019

Merged
merged 2 commits into from
Nov 18, 2022
Merged

fix: use list() on self mutating iteration #33019

merged 2 commits into from
Nov 18, 2022

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Nov 17, 2022

closes #30325

@ssiyad
fix: use list() on self mutating iteration
546c809 
frappe#30325

Signed-off-by: Sabu Siyad <hello@ssiyad.com>
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #33019 (0b5584a) into develop (cbe8fa7) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #33019   +/-   ##
========================================
  Coverage    63.83%   63.83%           
========================================
  Files          820      820           
  Lines        58766    58766           
========================================
  Hits         37512    37512           
  Misses       21254    21254
Impacted Files Coverage Δ
erpnext/erpnext_integrations/taxjar_integration.py 18.57% <0.00%> (ø)
erpnext/stock/report/stock_ledger/stock_ledger.py 75.77% <100.00%> (ø)

@s-aga-r s-aga-r merged commit d1f85dd into frappe:develop Nov 18, 2022
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Nov 18, 2022
This was referenced Nov 18, 2022
Merged
Merged
s-aga-r added a commit that referenced this pull request Nov 18, 2022
@s-aga-r
Merge pull request #33024 from frappe/mergify/bp/version-13-hotfix/pr…
00f990e 
…-33019

fix: use `list()` on self mutating iteration (backport #33019)
s-aga-r added a commit that referenced this pull request Nov 18, 2022
@s-aga-r
Merge pull request #33023 from frappe/mergify/bp/version-14-hotfix/pr…
f10d610 
…-33019

fix: use `list()` on self mutating iteration (backport #33019)
@ssiyad ssiyad deleted the fix/mutate_iter_list branch November 18, 2022 07:13
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-aga-r s-aga-r s-aga-r approved these changes

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not remove item from list while iterating the list
2 participants
@ssiyad @s-aga-r