fix: Valuation Rate column UX in stock ledger report #33088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
force-pushed
the
fixed-ux-for-valuation-rate
branch
from
119a952
to
be19e4f
Compare
rohitwaghchaure
added
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33088 +/- ##
========================================
Coverage 63.85% 63.85%
========================================
Files 820 820
Lines 58781 58785 +4
========================================
+ Hits 37537 37540 +3
- Misses 21244 21245 +1
|
deepeshgarg007
added a commit
that referenced
this pull request
Nov 23, 2022
…-33088 fix: Valuation Rate column UX in stock ledger report (backport #33088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Valuation Rate" in stock ledger report is the average cost of available balance and not a cost at which the Stock has either In-warded or Out-warded. Most of the time people get confused with it and their expectation is that the valuation rate should show the Rate at which the materials were either In-warded or Out-warded.
Solution
In this PR I have updated the column name of Valuation Rate to the Avg Rate (Balance Stock) and added new column Valuation Rate which will show the rate at which the materials were either In-warded or Out-warded.