Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove balance from Warehouse Tree #33199

Merged
merged 2 commits into from
Dec 2, 2022
Merged

refactor: remove balance from Warehouse Tree #33199

merged 2 commits into from
Dec 2, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Dec 1, 2022

Before:

image

After:

image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 1, 2022
@s-aga-r s-aga-r added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Merging #33199 (b3ae6cc) into develop (2106de0) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #33199      +/-   ##
===========================================
- Coverage    64.02%   64.01%   -0.02%     
===========================================
  Files          817      817              
  Lines        58593    58565      -28     
===========================================
- Hits         37517    37490      -27     
+ Misses       21076    21075       -1
Impacted Files Coverage Δ
...les_pipeline_analytics/sales_pipeline_analytics.py 86.70% <0.00%> (ø)
erpnext/stock/doctype/warehouse/warehouse.py 78.04% <100.00%> (-2.75%) ⬇️
erpnext/stock/doctype/serial_no/serial_no.py 88.96% <0.00%> (-0.24%) ⬇️

@s-aga-r s-aga-r marked this pull request as ready for review December 2, 2022 05:28
@rohitwaghchaure rohitwaghchaure merged commit 66dbf94 into frappe:develop Dec 2, 2022
@mergify mergify bot mentioned this pull request Dec 2, 2022
Merged
s-aga-r added a commit that referenced this pull request Dec 2, 2022
@s-aga-r
Merge pull request #33205 from frappe/mergify/bp/version-14-hotfix/pr…
5bdec0b 
…-33199

refactor: remove `balance` from `Warehouse Tree` (backport #33199)
@s-aga-r s-aga-r removed the backport version-14-hotfix backport to version 14 label Dec 2, 2022
@rohitwaghchaure rohitwaghchaure mentioned this pull request Dec 6, 2022
Merged
@s-aga-r s-aga-r deleted the refactor/warehouse-tree branch April 15, 2023 09:58
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@dj12djdjs dj12djdjs mentioned this pull request Mar 16, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-aga-r @rohitwaghchaure