Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow item rate updates for non-stock invoices #33219

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Dec 5, 2022

Currently, the valuation rate is forced for items in internal invoices even when the "update stock" check is not enabled.

In many scenarios, the user doesn't want to show the actual valuation rates to the receiving party of the invoices and use the price list rate only for such outgoing transactions.

This change allows users to make a Delivery Note/ Purchase Receipt for moving stock in and out and make invoices against them with the price list rate and apply taxes on them

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #33219 (ef9d126) into develop (2106de0) will decrease coverage by 0.01%.
The diff coverage is 84.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33219      +/-   ##
===========================================
- Coverage    64.02%   64.01%   -0.02%     
===========================================
  Files          817      817              
  Lines        58593    58579      -14     
===========================================
- Hits         37517    37499      -18     
- Misses       21076    21080       +4     
Impacted Files Coverage Δ
...ounts/doctype/purchase_invoice/purchase_invoice.py 83.90% <ø> (ø)
...stock/doctype/purchase_receipt/purchase_receipt.py 92.92% <ø> (ø)
erpnext/controllers/buying_controller.py 84.23% <71.42%> (-0.46%) ⬇️
erpnext/controllers/selling_controller.py 79.69% <91.66%> (+0.06%) ⬆️
erpnext/stock/doctype/warehouse/warehouse.py 78.04% <0.00%> (-2.75%) ⬇️
erpnext/setup/install.py 22.91% <0.00%> (-0.17%) ⬇️
...ype/repost_item_valuation/repost_item_valuation.py 71.09% <0.00%> (+1.21%) ⬆️

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2022

backport version-14-hotfix

✅ Backports have been created

@deepeshgarg007 deepeshgarg007 merged commit 921f8ed into frappe:develop Dec 6, 2022
deepeshgarg007 added a commit that referenced this pull request Dec 6, 2022
…-33219

fix: Allow item rate updates for non-stock invoices (backport #33219)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
buying needs-tests This PR needs automated unit-tests. selling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant