Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non empty FG batch picked while completing work order #33224

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Dec 5, 2022

Issue

  1. Created Work Order for 100 quantity and set Batch Size as "25" and enabled Skip Material Transfer
  2. After submit Work Order, system has created 4 Batches
  3. Created Partial Finish Stock Entry for 50 quantity, system has picked first 2 batches
  4. Created Partial Finish Stock Entry for remaining 50 quantity, system has picked again same 2 batches which was picked in above stock entry. Ideally it should pick remaining two empty batches.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #33224 (713330c) into develop (66dbf94) will increase coverage by 0.00%.
The diff coverage is 40.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33224   +/-   ##
========================================
  Coverage    64.01%   64.02%           
========================================
  Files          817      817           
  Lines        58577    58577           
========================================
+ Hits         37499    37503    +4     
+ Misses       21078    21074    -4     
Impacted Files Coverage Δ
erpnext/stock/doctype/stock_entry/stock_entry.py 81.47% <40.00%> (+0.07%) ⬆️
erpnext/stock/doctype/serial_no/serial_no.py 88.96% <0.00%> (-0.24%) ⬇️
...ext/manufacturing/doctype/work_order/work_order.py 79.61% <0.00%> (+0.55%) ⬆️

@rohitwaghchaure rohitwaghchaure merged commit d0478ec into frappe:develop Dec 5, 2022
rohitwaghchaure added a commit that referenced this pull request Dec 5, 2022
…-33224

fix: non empty FG batch picked while completing work order (backport #33224)
rohitwaghchaure added a commit that referenced this pull request Dec 5, 2022
…-33224

fix: non empty FG batch picked while completing work order (backport #33224)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant