Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add operating cost based on bom quanity without creating job card #33347

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

vishdha
Copy link
Contributor

@vishdha vishdha commented Dec 15, 2022

Problem Statement: Across Manufacturing organisation with multiple operation and illiterate job worker its difficult to create job card. Hence it should be record operating cost per finished good Item.
Step 1. Add Per BOM quantity operating cost in bom
Step 2. You will see Planned operating cost in BOM
Setp 3. In Manufactured Stock Entry it will record operating_cost_per_bom_quantity * FG Quantity

Why this change:

  1. Need operating cost but want to skip job card need sku based operating cost.

Step1. Add operating cost per BOM quanity. operating cost = 45*10 = 450 as shown in pic
BOM-Makhana_7-107-006

Final Manufactured stock entry without job card
Manufacture-MAT-STE-2022-00088

GIF:

BOM-Makhana_7-107-006.mp4

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 15, 2022
@vishdha
Copy link
Contributor Author

vishdha commented Dec 15, 2022

backport this to version 14

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #33347 (9fd1c3e) into develop (f4a1218) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33347   +/-   ##
========================================
  Coverage    64.09%   64.09%           
========================================
  Files          818      818           
  Lines        58867    58872    +5     
========================================
+ Hits         37728    37733    +5     
  Misses       21139    21139           
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/bom/bom.py 88.08% <100.00%> (+0.09%) ⬆️

@vishdha
Copy link
Contributor Author

vishdha commented Dec 19, 2022

@rohitwaghchaure Test Case added for this feature

@vishdha
Copy link
Contributor Author

vishdha commented Dec 20, 2022

@s-aga-r @rohitwaghchaure anything else needed?

@stale
Copy link

stale bot commented Jan 6, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jan 6, 2023
@stale stale bot removed the inactive label Jan 6, 2023
@vishdha
Copy link
Contributor Author

vishdha commented Jan 9, 2023

@rohitwaghchaure anything missing in this pr?

@rohitwaghchaure rohitwaghchaure merged commit 20fe187 into frappe:develop Jan 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants