Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsupported operand type(s) for +: 'int' and 'NoneType' #33354

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Error

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 69, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 55, in handle
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 38, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 76, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1457, in call
    return fn(*args, **newargs)
  File "apps/erpnext/erpnext/stock/get_item_details.py", line 91, in get_item_details
    out.update(get_price_list_rate(args, item))
  File "apps/erpnext/erpnext/stock/get_item_details.py", line 792, in get_price_list_rate
    insert_item_price(args)
  File "apps/erpnext/erpnext/stock/get_item_details.py", line 817, in insert_item_price
    if args.get("conversion_factor")
TypeError: unsupported operand type(s) for +: 'int' and 'NoneType'

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Dec 15, 2022
@rohitwaghchaure rohitwaghchaure added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #33354 (0f28074) into develop (c5d21b2) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33354      +/-   ##
===========================================
+ Coverage    63.96%   64.00%   +0.03%     
===========================================
  Files          818      818              
  Lines        58620    58628       +8     
===========================================
+ Hits         37497    37523      +26     
+ Misses       21123    21105      -18     
Impacted Files Coverage Δ
erpnext/stock/get_item_details.py 80.38% <ø> (ø)
erpnext/controllers/status_updater.py 88.23% <0.00%> (-0.48%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 77.81% <0.00%> (-0.27%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.75% <0.00%> (-0.09%) ⬇️
...xt/accounts/doctype/payment_entry/payment_entry.py 72.54% <0.00%> (-0.07%) ⬇️
erpnext/accounts/utils.py 74.24% <0.00%> (+0.03%) ⬆️
erpnext/stock/doctype/serial_no/serial_no.py 89.43% <0.00%> (+0.23%) ⬆️
erpnext/stock/doctype/stock_entry/stock_entry.py 82.23% <0.00%> (+0.78%) ⬆️
...e/payment_reconciliation/payment_reconciliation.py 93.96% <0.00%> (+1.04%) ⬆️
...ext/manufacturing/doctype/work_order/work_order.py 80.99% <0.00%> (+1.38%) ⬆️

@rohitwaghchaure rohitwaghchaure merged commit 5cbbb5d into frappe:develop Dec 15, 2022
rohitwaghchaure added a commit that referenced this pull request Dec 15, 2022
…-33354

fix: unsupported operand type(s) for +: 'int' and 'NoneType' (backport #33354)
rohitwaghchaure added a commit that referenced this pull request Dec 15, 2022
…-33354

fix: unsupported operand type(s) for +: 'int' and 'NoneType' (backport #33354)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant