Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore company related doctype for other apps via hooks #33362

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Dec 15, 2022

Ignore company linked doctypes from other apps via hooks on clearing transactions

no-docs

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #33362 (1a40c04) into develop (b179514) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33362      +/-   ##
===========================================
+ Coverage    63.97%   64.00%   +0.02%     
===========================================
  Files          818      818              
  Lines        58641    58629      -12     
===========================================
+ Hits         37516    37525       +9     
+ Misses       21125    21104      -21     
Impacted Files Coverage Δ
...ion_deletion_record/transaction_deletion_record.py 90.56% <100.00%> (+0.08%) ⬆️
...t/support/doctype/warranty_claim/warranty_claim.py 31.25% <0.00%> (-1.11%) ⬇️
...nce/doctype/maintenance_visit/maintenance_visit.py 59.25% <0.00%> (-0.99%) ⬇️
erpnext/buying/doctype/supplier/supplier.py 76.74% <0.00%> (-0.53%) ⬇️
erpnext/controllers/status_updater.py 88.23% <0.00%> (-0.48%) ⬇️
erpnext/support/doctype/issue/issue.py 64.90% <0.00%> (-0.34%) ⬇️
erpnext/projects/doctype/project/project.py 51.30% <0.00%> (-0.32%) ⬇️
erpnext/projects/doctype/task/task.py 65.48% <0.00%> (-0.31%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 77.81% <0.00%> (-0.27%) ⬇️
erpnext/crm/doctype/lead/lead.py 71.55% <0.00%> (-0.25%) ⬇️
... and 16 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2022

backport version-14-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Dec 16, 2022
…-33362

feat: Ignore company related doctype for other apps via hooks (backport #33362)
@sagarvora
Copy link
Collaborator

sagarvora commented Dec 16, 2022

Alternatively, ignoring children of single doctypes might've worked as well. We are already ignoring singles:

singles = frappe.get_all("DocType", filters={"issingle": 1}, pluck="name")

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants