Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ERR journals should be reported in AR/AP #33380

Conversation

ruthra-kumar
Copy link
Member

Exchange Rate Revaluation journals for Party should be reported in Accounts Receivable/Payable.

Party with Balance in Foreign Currency:

Screenshot 2022-12-18 at 6 59 35 AM

Screenshot 2022-12-18 at 7 00 03 AM

Screenshot 2022-12-18 at 7 06 54 AM

Exchange Rate Revaluation for Party:
Screenshot 2022-12-18 at 7 02 38 AM

Screenshot 2022-12-18 at 7 02 52 AM

Accounts Receivable Report:
Screenshot 2022-12-18 at 7 03 09 AM

Exchange Rate Revaluation on Receivable/Payable will included in AR/AP report
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 18, 2022
@ruthra-kumar ruthra-kumar marked this pull request as draft December 18, 2022 02:26
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #33380 (2ed8676) into develop (2e2590b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33380      +/-   ##
===========================================
+ Coverage    64.02%   64.05%   +0.02%     
===========================================
  Files          817      818       +1     
  Lines        58590    58643      +53     
===========================================
+ Hits         37514    37563      +49     
- Misses       21076    21080       +4     
Impacted Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 72.07% <100.00%> (+0.96%) ⬆️
erpnext/stock/doctype/warehouse/warehouse.py 78.04% <0.00%> (-2.75%) ⬇️
erpnext/erpnext_integrations/stripe_integration.py 16.21% <0.00%> (-1.97%) ⬇️
...rpnext/accounts/doctype/fiscal_year/fiscal_year.py 56.00% <0.00%> (-1.15%) ⬇️
...t/support/doctype/warranty_claim/warranty_claim.py 31.25% <0.00%> (-1.11%) ⬇️
...nce/doctype/maintenance_visit/maintenance_visit.py 59.25% <0.00%> (-0.99%) ⬇️
erpnext/selling/doctype/customer/customer.py 73.61% <0.00%> (-0.66%) ⬇️
...eport/sales_order_analysis/sales_order_analysis.py 79.38% <0.00%> (-0.62%) ⬇️
erpnext/controllers/buying_controller.py 84.11% <0.00%> (-0.58%) ⬇️
erpnext/buying/doctype/supplier/supplier.py 76.74% <0.00%> (-0.53%) ⬇️
... and 42 more

@ruthra-kumar ruthra-kumar marked this pull request as ready for review December 18, 2022 11:25
@ruthra-kumar ruthra-kumar merged commit 65db9ce into frappe:develop Dec 18, 2022
@ruthra-kumar ruthra-kumar changed the title fix: ERR journals should reported in AR/AP fix: ERR journals should be reported in AR/AP Dec 18, 2022
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2022

backport version-13-hotfix

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2022

backport version-14-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Dec 28, 2022
…-33380

fix: ERR journals should be reported in AR/AP (backport #33380)
ruthra-kumar added a commit that referenced this pull request Dec 29, 2022
…-33380

fix: ERR journals should be reported in AR/AP (backport #33380)
@ruthra-kumar ruthra-kumar deleted the err_for_invoices_should_reflect_in_ar_ap_report branch June 14, 2023 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant