Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better handling of duplicate bundle items #33562

Merged

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jan 6, 2023

  1. Make Sales Order with Bundled Item
  2. Save
  3. Add the Same Bundled Item and remove the first item
  4. Save

Items from bundle [1] will still be in Packed Item table.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #33562 (b56c1ed) into develop (fa4af2a) will increase coverage by 0.08%.
The diff coverage is 91.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33562      +/-   ##
===========================================
+ Coverage    64.09%   64.17%   +0.08%     
===========================================
  Files          818      819       +1     
  Lines        58886    59031     +145     
===========================================
+ Hits         37742    37883     +141     
- Misses       21144    21148       +4     
Impacted Files Coverage Δ
...s_and_balances/asset_depreciations_and_balances.py 0.00% <ø> (ø)
...eport/fixed_asset_register/fixed_asset_register.py 0.00% <ø> (ø)
...rpnext/assets/doctype/asset_repair/asset_repair.py 66.04% <40.00%> (-0.83%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 86.55% <89.70%> (+0.84%) ⬆️
...preciation_schedule/asset_depreciation_schedule.py 92.27% <92.27%> (ø)
...e/asset_value_adjustment/asset_value_adjustment.py 89.36% <95.23%> (+1.40%) ⬆️
erpnext/assets/doctype/asset/asset.py 81.48% <96.61%> (-0.77%) ⬇️
...xt/accounts/doctype/journal_entry/journal_entry.py 68.64% <100.00%> (+0.04%) ⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.88% <100.00%> (+0.04%) ⬆️
...ctype/asset_capitalization/asset_capitalization.py 92.89% <100.00%> (+0.06%) ⬆️
... and 2 more

@ruthra-kumar ruthra-kumar marked this pull request as ready for review January 6, 2023 11:37
@s-aga-r s-aga-r added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Jan 9, 2023
@s-aga-r s-aga-r merged commit dd3b79b into frappe:develop Jan 9, 2023
s-aga-r added a commit that referenced this pull request Jan 9, 2023
…-33562

fix: better handling of duplicate bundle items (backport #33562)
s-aga-r added a commit that referenced this pull request Jan 9, 2023
…-33562

fix: better handling of duplicate bundle items (backport #33562)
@ruthra-kumar ruthra-kumar deleted the better_handling_of_duplicate_bundle_items branch June 14, 2023 16:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants