-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rewrite logic for duplicate check in Item Attribute #33619
Conversation
Previously, Item Attribute values were not checked for case-insensitive duplicates, and Item tttribute abbreviations were forced to be uppercase. This commit fixes both problems.
@SvbZ3r0 please fix the failing test. |
I've fixed the formatting, but I'm not sure what the other failing tests have to do with any changes I made here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33619 +/- ##
========================================
Coverage 64.14% 64.14%
========================================
Files 819 819
Lines 59165 59093 -72
========================================
- Hits 37950 37906 -44
+ Misses 21215 21187 -28
|
@s-aga-r This is passing all tests. Let me know if I need to change anything else. |
…-33619 fix: rewrite logic for duplicate check in Item Attribute (backport #33619)
…-33619 fix: rewrite logic for duplicate check in Item Attribute (backport #33619)
Previously, Item Attribute values were not checked for case-insensitive duplicates, and Item tttribute abbreviations were forced to be uppercase. This commit fixes both problems.
Fixes: #22256
Partially fixes: #15467