Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite logic for duplicate check in Item Attribute #33619

Merged
merged 5 commits into from
Jan 19, 2023
Merged

fix: rewrite logic for duplicate check in Item Attribute #33619

merged 5 commits into from
Jan 19, 2023

Conversation

SvbZ3r0
Copy link
Contributor

@SvbZ3r0 SvbZ3r0 commented Jan 12, 2023

Previously, Item Attribute values were not checked for case-insensitive duplicates, and Item tttribute abbreviations were forced to be uppercase. This commit fixes both problems.

Fixes: #22256
Partially fixes: #15467

Previously, Item Attribute values were not checked for case-insensitive duplicates, and Item tttribute abbreviations were forced to be uppercase. This commit fixes both problems.
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 12, 2023
@s-aga-r
Copy link
Contributor

s-aga-r commented Jan 12, 2023

@SvbZ3r0 please fix the failing test.

@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Jan 12, 2023

I've fixed the formatting, but I'm not sure what the other failing tests have to do with any changes I made here.

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #33619 (bfbc9ea) into develop (2c83fff) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head bfbc9ea differs from pull request most recent head 333b2ae. Consider uploading reports for the commit 333b2ae to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33619   +/-   ##
========================================
  Coverage    64.14%   64.14%           
========================================
  Files          819      819           
  Lines        59165    59093   -72     
========================================
- Hits         37950    37906   -44     
+ Misses       21215    21187   -28     
Impacted Files Coverage Δ
...ext/stock/doctype/item_attribute/item_attribute.py 88.09% <50.00%> (-0.28%) ⬇️
erpnext/stock/doctype/pick_list/pick_list.py 76.59% <0.00%> (-1.36%) ⬇️
erpnext/stock/doctype/serial_no/serial_no.py 89.20% <0.00%> (-0.24%) ⬇️
erpnext/stock/get_item_details.py 80.61% <0.00%> (-0.18%) ⬇️
...e/payment_reconciliation/payment_reconciliation.py 96.99% <0.00%> (-0.02%) ⬇️
erpnext/controllers/taxes_and_totals.py 95.15% <0.00%> (-0.01%) ⬇️
...rpnext/assets/doctype/asset_repair/asset_repair.py 66.04% <0.00%> (ø)
.../report/tds_payable_monthly/tds_payable_monthly.py 0.00% <0.00%> (ø)
...ype/repost_payment_ledger/repost_payment_ledger.py 0.00% <0.00%> (ø)
...x_withholding_category/tax_withholding_category.py 85.90% <0.00%> (ø)
... and 8 more

@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Jan 15, 2023

@s-aga-r This is passing all tests. Let me know if I need to change anything else.

@s-aga-r s-aga-r added version-11 backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. version-11 labels Jan 19, 2023
@s-aga-r s-aga-r merged commit cceb792 into frappe:develop Jan 19, 2023
s-aga-r added a commit that referenced this pull request Jan 19, 2023
…-33619

fix: rewrite logic for duplicate check in Item Attribute (backport #33619)
s-aga-r added a commit that referenced this pull request Jan 19, 2023
…-33619

fix: rewrite logic for duplicate check in Item Attribute (backport #33619)
@SvbZ3r0 SvbZ3r0 deleted the item-attr-abbr-lowercase branch January 20, 2023 07:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants