Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: purchase invoice performance issue #33722

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Jan 18, 2023

  1. Enabled search index for fields 'purchase_receipt_item' and 'purchase_invoice_item' in the doctype 'Purchase Receipt Item'
  2. Get invoiced amount based on purchase receipts and Get returned quantity based on purchase receipts are running in the for loop which causing the performance issue

@rohitwaghchaure rohitwaghchaure marked this pull request as draft January 18, 2023 17:38
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 18, 2023
@rohitwaghchaure rohitwaghchaure force-pushed the purchase-invoice-performance-issue branch from d87dbeb to 92d857d Compare January 24, 2023 17:02
@stale
Copy link

stale bot commented Feb 9, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Feb 9, 2023
@stale stale bot closed this Feb 12, 2023
@stale stale bot removed the inactive label Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #33722 (4726448) into develop (6b3028d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33722   +/-   ##
========================================
  Coverage    63.89%   63.89%           
========================================
  Files          817      817           
  Lines        59337    59348   +11     
========================================
+ Hits         37912    37922   +10     
- Misses       21425    21426    +1     
Impacted Files Coverage Δ
...ounts/doctype/purchase_invoice/purchase_invoice.py 84.09% <100.00%> (+0.18%) ⬆️
...stock/doctype/purchase_receipt/purchase_receipt.py 92.97% <100.00%> (+0.05%) ⬆️
erpnext/stock/doctype/serial_no/serial_no.py 89.20% <0.00%> (-0.24%) ⬇️

@rohitwaghchaure rohitwaghchaure marked this pull request as ready for review February 19, 2023 05:38
@rohitwaghchaure rohitwaghchaure merged commit 3871cf7 into frappe:develop Feb 20, 2023
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Feb 20, 2023
rohitwaghchaure added a commit that referenced this pull request Feb 20, 2023
…-33722

fix: purchase invoice performance issue (backport #33722)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant