Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(region): Splitting of KSA(Saudi Arabia) Region from ERPNext #33895

Merged
merged 8 commits into from
Feb 21, 2023

Conversation

sankarsubramaniankvs
Copy link
Contributor

@sankarsubramaniankvs sankarsubramaniankvs commented Jan 31, 2023

This Pull Request Will remove the code related to Saudi Arabia Region from ERPNext. It will come in a separate app that will be published in the frappe marketplace and will be used only by companies that need KSA Compliance. The idea behind it is to remove code unnecessary for a user. ERPNext should only have a generic code that can be used by everyone.

Link to new app: https://github.com/8848digital/KSA

Copy link
Member

@deepeshgarg007 deepeshgarg007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erpnext/hooks.py Show resolved Hide resolved
erpnext/hooks.py Show resolved Hide resolved
erpnext/hooks.py Show resolved Hide resolved
erpnext/hooks.py Show resolved Hide resolved
@sankarsubramaniankvs
Copy link
Contributor Author

erpnext

I have added the patches

@deepeshgarg007
Copy link
Member

2 checks also failing, please fix them

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #33895 (bce4269) into develop (3f2a2c9) will increase coverage by 0.19%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33895      +/-   ##
===========================================
+ Coverage    63.85%   64.05%   +0.19%     
===========================================
  Files          817      810       -7     
  Lines        59494    59283     -211     
===========================================
- Hits         37992    37974      -18     
+ Misses       21502    21309     -193     
Impacted Files Coverage Δ
erpnext/hooks.py 100.00% <ø> (ø)
...x_withholding_category/tax_withholding_category.py 85.95% <0.00%> (-0.01%) ⬇️
...eport/fixed_asset_register/fixed_asset_register.py 0.00% <0.00%> (ø)
...ion_deletion_record/transaction_deletion_record.py 90.59% <0.00%> (+0.03%) ⬆️

@deepeshgarg007 deepeshgarg007 merged commit a06d240 into frappe:develop Feb 21, 2023
@barredterra
Copy link
Collaborator

@sankarsubramaniankvs you forgot to clean up the accounting workspace:

{
"dependencies": "GL Entry",
"hidden": 0,
"is_query_report": 1,
"label": "KSA VAT Report",
"link_count": 0,
"link_to": "KSA VAT",
"link_type": "Report",
"onboard": 0,
"only_for": "Saudi Arabia",
"type": "Link"
},

{
"hidden": 0,
"is_query_report": 0,
"label": "KSA VAT Setting",
"link_count": 0,
"link_to": "KSA VAT Setting",
"link_type": "DocType",
"onboard": 0,
"only_for": "Saudi Arabia",
"type": "Link"
},

@sankarsubramaniankvs
Copy link
Contributor Author

Hi @barredterra. Thanks for bringing this to my notice. will check this out

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants