-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(region): Splitting of KSA(Saudi Arabia) Region from ERPNext #33895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a depreciation warning on version-14 like https://github.com/frappe/erpnext/pull/30861/files
Add a patch to delete doctypes from old modules https://github.com/frappe/erpnext/pull/30830/files#diff-bdbb775d3a1469cacdfc456d9abbc26cc35c72fdeeeb96d6db481d3856a11abaR1
I have added the patches |
2 checks also failing, please fix them |
b20ce89
to
89661b6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33895 +/- ##
===========================================
+ Coverage 63.85% 64.05% +0.19%
===========================================
Files 817 810 -7
Lines 59494 59283 -211
===========================================
- Hits 37992 37974 -18
+ Misses 21502 21309 -193
|
@sankarsubramaniankvs you forgot to clean up the accounting workspace: erpnext/erpnext/accounts/workspace/accounting/accounting.json Lines 519 to 530 in c3d4556
erpnext/erpnext/accounts/workspace/accounting/accounting.json Lines 1032 to 1042 in c3d4556
|
Hi @barredterra. Thanks for bringing this to my notice. will check this out |
This Pull Request Will remove the code related to Saudi Arabia Region from ERPNext. It will come in a separate app that will be published in the frappe marketplace and will be used only by companies that need KSA Compliance. The idea behind it is to remove code unnecessary for a user. ERPNext should only have a generic code that can be used by everyone.
Link to new app: https://github.com/8848digital/KSA