-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow cancelling purchase invoice if linked asset is already cancelled #33946
Merged
anandbaburajan
merged 6 commits into
frappe:develop
from
anandbaburajan:cancel_pi_cancelled_asset
Feb 5, 2023
Merged
fix: allow cancelling purchase invoice if linked asset is already cancelled #33946
anandbaburajan
merged 6 commits into
frappe:develop
from
anandbaburajan:cancel_pi_cancelled_asset
Feb 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33946 +/- ##
===========================================
- Coverage 63.89% 63.89% -0.01%
===========================================
Files 818 818
Lines 59284 59286 +2
===========================================
+ Hits 37877 37878 +1
- Misses 21407 21408 +1
|
anandbaburajan
added a commit
that referenced
this pull request
Feb 5, 2023
…-33946 fix: allow cancelling purchase invoice if linked asset is already cancelled (backport #33946)
anandbaburajan
added a commit
that referenced
this pull request
Feb 10, 2023
…-33946 fix: allow cancelling purchase invoice if linked asset is already cancelled (backport #33946)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport version-13-hotfix
backport version-14-hotfix
backport to version 14
buying
needs-tests
This PR needs automated unit-tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users weren't able to cancel a PI if an asset linked to it if was already cancelled, so fixed that.