Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow cancelling purchase invoice if linked asset is already cancelled #33946

Merged
merged 6 commits into from
Feb 5, 2023
Merged

fix: allow cancelling purchase invoice if linked asset is already cancelled #33946

merged 6 commits into from
Feb 5, 2023

Conversation

anandbaburajan
Copy link
Contributor

Users weren't able to cancel a PI if an asset linked to it if was already cancelled, so fixed that.

@github-actions github-actions bot added buying needs-tests This PR needs automated unit-tests. labels Feb 3, 2023
@anandbaburajan anandbaburajan marked this pull request as draft February 4, 2023 05:45
@anandbaburajan anandbaburajan marked this pull request as ready for review February 4, 2023 05:50
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #33946 (4686217) into develop (52435a3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33946      +/-   ##
===========================================
- Coverage    63.89%   63.89%   -0.01%     
===========================================
  Files          818      818              
  Lines        59284    59286       +2     
===========================================
+ Hits         37877    37878       +1     
- Misses       21407    21408       +1     
Impacted Files Coverage Δ
erpnext/controllers/buying_controller.py 83.78% <0.00%> (-0.42%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 82.14% <0.00%> (+0.08%) ⬆️

@anandbaburajan anandbaburajan merged commit 9d8502f into frappe:develop Feb 5, 2023
anandbaburajan added a commit that referenced this pull request Feb 5, 2023
…-33946

fix: allow cancelling purchase invoice if linked asset is already cancelled (backport #33946)
anandbaburajan added a commit that referenced this pull request Feb 10, 2023
…-33946

fix: allow cancelling purchase invoice if linked asset is already cancelled (backport #33946)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 buying needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant