Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show Purchase Order Portal Pay button based on configuration #34077

Merged
merged 8 commits into from
Feb 18, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Feb 15, 2023

source/ref: ISS-22-23-05031

Changes:

  • Add show_pay_button field in Buying Settings.

    image

  • Show the Pay button in the Purchase Order Portal based on the configuration from Buying Settings

    image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 15, 2023
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #34077 (91983fb) into develop (6b3028d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34077      +/-   ##
===========================================
- Coverage    63.89%   63.88%   -0.01%     
===========================================
  Files          817      817              
  Lines        59337    59338       +1     
===========================================
- Hits         37912    37910       -2     
- Misses       21425    21428       +3     
Impacted Files Coverage Δ
erpnext/templates/pages/order.py 0.00% <0.00%> (ø)
erpnext/stock/stock_ledger.py 89.92% <0.00%> (-0.32%) ⬇️

@s-aga-r s-aga-r marked this pull request as ready for review February 15, 2023 10:31
@s-aga-r s-aga-r changed the title fix: show Pay button on configuration in Buying Settings fix: show Pay button based on configuration in Buying Settings Feb 15, 2023
@s-aga-r s-aga-r changed the title fix: show Pay button based on configuration in Buying Settings fix: show Purchase Order Pay button based on configuration Feb 15, 2023
@s-aga-r s-aga-r changed the title fix: show Purchase Order Pay button based on configuration fix: show Purchase Order Portal Pay button based on configuration Feb 15, 2023
@s-aga-r s-aga-r merged commit c292859 into frappe:develop Feb 18, 2023
s-aga-r added a commit that referenced this pull request Feb 18, 2023
…-34077

fix: show Purchase Order Portal `Pay` button based on configuration (backport #34077)
@s-aga-r s-aga-r deleted the purchase-order-portal branch April 15, 2023 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant