Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect consumed qty in subcontracting receipt #34091

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  1. Set "Backflush Raw Materials of Subcontract Based On" as "BOM" in the buying settings,
  2. Make sure raw materials are having batches
  3. Transferred raw materials less to the supplier through stock entry
  4. While making subcontracting receipt, you will notice extra row with zero consumed qty

Screenshot 2023-02-16 at 1 23 10 PM

@rohitwaghchaure rohitwaghchaure force-pushed the fixed-incorrect-consumed-qty-in-scr branch from 4cd42ab to 156e459 Compare February 16, 2023 08:48
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #34091 (156e459) into develop (192a339) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34091      +/-   ##
===========================================
+ Coverage    63.86%   63.89%   +0.02%     
===========================================
  Files          818      817       -1     
  Lines        59328    59331       +3     
===========================================
+ Hits         37892    37907      +15     
+ Misses       21436    21424      -12     
Impacted Files Coverage Δ
erpnext/controllers/subcontracting_controller.py 87.89% <100.00%> (+0.05%) ⬆️
erpnext/assets/doctype/asset/asset.py 80.23% <0.00%> (-0.19%) ⬇️
...ccounts/doctype/payment_request/payment_request.py 67.98% <0.00%> (-0.11%) ⬇️
.../setup/setup_wizard/operations/install_fixtures.py 90.90% <0.00%> (-0.08%) ⬇️
erpnext/accounts/utils.py 75.03% <0.00%> (ø)
erpnext/controllers/sales_and_purchase_return.py 91.78% <0.00%> (ø)
...eport/fixed_asset_register/fixed_asset_register.py 0.00% <0.00%> (ø)
...eport/sales_order_analysis/sales_order_analysis.py 79.38% <0.00%> (ø)
...s_and_balances/asset_depreciations_and_balances.py 0.00% <0.00%> (ø)
erpnext/setup/setup_wizard/data/industry_type.py
... and 4 more

@rohitwaghchaure rohitwaghchaure merged commit 4399a93 into frappe:develop Feb 16, 2023
s-aga-r added a commit that referenced this pull request Feb 16, 2023
…-34091

fix: incorrect consumed qty in subcontracting receipt (backport #34091)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant