Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair status after deletion, asset status after manual depr entry and other misc bugs [develop] #34111

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

anandbaburajan
Copy link
Contributor

  • When the Asset Repair Status is changed to Completed/Cancelled and the doc is submitted, the asset's status is changed (not Out of Order anymore). But the status doesn't change when the Asset Repair doc is directly deleted -- it remains Out of Order, so fixed that
  • After doing a manual depreciation entry for an asset, the status remains Submitted. It should change to Partially Depreciated or Fully Depreciated, so fixed that
  • If multiple manual depr entries are created on same date, order by creation date
  • Fixed minor rounding issue in asset chart

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #34111 (e50bd52) into develop (067f8c1) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #34111   +/-   ##
========================================
  Coverage    63.89%   63.89%           
========================================
  Files          817      817           
  Lines        59331    59337    +6     
========================================
+ Hits         37907    37912    +5     
- Misses       21424    21425    +1     
Impacted Files Coverage Δ
...rpnext/assets/doctype/asset_repair/asset_repair.py 65.85% <50.00%> (-0.20%) ⬇️
...xt/accounts/doctype/journal_entry/journal_entry.py 69.71% <100.00%> (+0.08%) ⬆️
erpnext/assets/doctype/asset/asset.py 80.30% <100.00%> (+0.07%) ⬆️
erpnext/assets/doctype/asset/depreciation.py 82.30% <100.00%> (ø)

@anandbaburajan anandbaburajan merged commit 6b3028d into frappe:develop Feb 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant