fix: Gross Profit reports Invoices with -ve qty for Invoices with Cr Notes

[ruthra-kumar]

Issue

1. Create Invoice with 2 rows of same item.
2. Make a credit note for [1]
3. GP report for [1] will have -ve qty and incorrect selling amount due to the -ve quantity

Cr note is overallocated to the Parent Invoice while calculating Average rate. This only happens if multiple rows have the same item.

Changes in this PR:

1. Overallocation issue mentioned above has been fixed.
2. Cr notes with 'return_against'(parent invoice) will be ignored by the report. Item quantities of those Cr notes are applied against the Original Invoice, there is no need to report them separately.
3. Standalone CR Notes will be reported as usual.

Invoice SINV-23-00056 with multiple rows of same item.

Cr Note, SINV-23-00058, against SINV-23-00056

Standalone Cr Note SINV-23-00057

Before Fix:

1. Item quantities of SINV-23-00056 goes to -ve due to overallocation mentioned above.
2. It's Cr Note SINV-23-00058 is also reported as a separate Invoice

After Fix:

1. SINV-23-00056 has correct qty(0) as the Cr note should negate the Original invoice.
2. Cr Note SINV-23-00058 is not reported.

[codecov]

Codecov Report

Merging #34456 (cc61dae) into develop (1d767d5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #34456      +/-   ##
===========================================
+ Coverage    63.86%   63.87%   +0.01%     
===========================================
  Files          810      810              
  Lines        59520    59526       +6     
===========================================
+ Hits         38010    38022      +12     
+ Misses       21510    21504       -6     

Impacted Files	Coverage Δ
...pnext/accounts/report/gross_profit/gross_profit.py	87.76% <100.00%> (+2.09%)	⬆️

... and 2 files with indirect coverage changes

[ruthra-kumar]

@Mergifyio backport version-14-hotfix version-13-hotfix

[mergify]

backport version-14-hotfix version-13-hotfix

✅ Backports have been created

• Backport to branch version-14-hotfix in progress
• #34490 fix: Gross Profit reports Invoices with -ve qty for Invoices with Cr Notes (backport #34456) has been created for branch version-13-hotfix

[ruthra-kumar]

@Mergifyio backport version-14-hotfix

[mergify]

backport version-14-hotfix

❌ No backport have been created

• Backport to branch version-14-hotfix failed

Git reported the following error:

To https://github.com/frappe/erpnext
 ! [rejected]              mergify/bp/version-14-hotfix/pr-34456 -> mergify/bp/version-14-hotfix/pr-34456 (non-fast-forward)
error: failed to push some refs to 'https://github.com/frappe/erpnext'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.