Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect depr schedules after asset repair [develop] #34544

Merged
merged 3 commits into from
Mar 21, 2023
Merged

fix: incorrect depr schedules after asset repair [develop] #34544

merged 3 commits into from
Mar 21, 2023

Conversation

anandbaburajan
Copy link
Contributor

Depreciation schedules after asset repair were incorrectly calculated in case of asset value/life increase, so fixed it.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #34544 (4c3bba9) into develop (d8e73b6) will decrease coverage by 0.01%.
The diff coverage is 54.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34544      +/-   ##
===========================================
- Coverage    63.79%   63.78%   -0.01%     
===========================================
  Files          809      809              
  Lines        59347    59368      +21     
===========================================
+ Hits         37859    37868       +9     
- Misses       21488    21500      +12     
Impacted Files Coverage Δ
...rpnext/assets/doctype/asset_repair/asset_repair.py 63.53% <45.00%> (-2.32%) ⬇️
erpnext/assets/doctype/asset/asset.py 80.45% <100.00%> (+0.14%) ⬆️
...preciation_schedule/asset_depreciation_schedule.py 91.88% <100.00%> (-0.43%) ⬇️

... and 1 file with indirect coverage changes

@anandbaburajan anandbaburajan merged commit 6d6a7bc into frappe:develop Mar 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant